Sem-Ver: bugfix Deduplicate the various framework test create_token methods.

Signed-off-by: David Black <[email protected]>

Author: dbaxa

atlassian_jwt_auth/frameworks/django/tests/test_django.py

@@ -3,20 +3,20 @@
 import django
 from django.test.testcases import SimpleTestCase
 from django.test.utils import override_settings, modify_settings
+
 try:
     from django.urls import reverse
 except ImportError:
     from django.core.urlresolvers import reverse
 
-from atlassian_jwt_auth import create_signer
-from atlassian_jwt_auth.contrib.tests.utils import get_static_retriever_class
+from atlassian_jwt_auth.contrib.tests.utils import (
+    get_static_retriever_class,
+)
 from atlassian_jwt_auth.tests import utils
-from atlassian_jwt_auth.tests.utils import RS256KeyTestMixin
-
-
-def create_token(issuer, audience, key_id, private_key, subject=None):
-    signer = create_signer(issuer, key_id, private_key, subject=subject)
-    return signer.generate_jwt(audience)
+from atlassian_jwt_auth.tests.utils import (
+    create_token,
+    RS256KeyTestMixin,
+)
 
 
 class DjangoAsapMixin(object):

atlassian_jwt_auth/frameworks/flask/tests/test_flask.py

@@ -2,11 +2,13 @@
 
 from flask import Flask
 
-import atlassian_jwt_auth
-from atlassian_jwt_auth.tests import utils
-from atlassian_jwt_auth.frameworks.flask import with_asap
 from atlassian_jwt_auth.contrib.flask_app import requires_asap
 from atlassian_jwt_auth.contrib.tests.utils import get_static_retriever_class
+from atlassian_jwt_auth.frameworks.flask import with_asap
+from atlassian_jwt_auth.tests import utils
+from atlassian_jwt_auth.tests.utils import (
+    create_token,
+)
 
 
 def get_app():
@@ -30,13 +32,6 @@ def view_for_another_client_app():
     return app
 
 
-def create_token(issuer, audience, key_id, private_key):
-    signer = atlassian_jwt_auth.create_signer(
-        issuer, key_id, private_key
-    )
-    return signer.generate_jwt(audience)
-
-
 class FlaskTests(utils.RS256KeyTestMixin, unittest.TestCase):
     """ tests for the atlassian_jwt_auth.contrib.tests.flask """
 

atlassian_jwt_auth/frameworks/wsgi/tests/test_wsgi.py

@@ -1,23 +1,18 @@
 import unittest
 
-import atlassian_jwt_auth
-from atlassian_jwt_auth.tests import utils
 from atlassian_jwt_auth.contrib.tests.utils import get_static_retriever_class
 from atlassian_jwt_auth.frameworks.wsgi.middleware import ASAPMiddleware
+from atlassian_jwt_auth.tests import utils
+from atlassian_jwt_auth.tests.utils import (
+    create_token,
+)
 
 
 def app(environ, start_response):
     start_response('200 OK', [], None)
     return "OK"
 
 
-def create_token(issuer, audience, key_id, private_key):
-    signer = atlassian_jwt_auth.create_signer(
-        issuer, key_id, private_key
-    )
-    return signer.generate_jwt(audience)
-
-
 class WsgiTests(utils.RS256KeyTestMixin, unittest.TestCase):
     """ tests for the atlassian_jwt_auth.contrib.tests.flask """
 

atlassian_jwt_auth/tests/utils.py

@@ -41,6 +41,13 @@ def get_example_jwt_auth_signer(**kwargs):
         issuer, key_id, key, algorithm=algorithm)
 
 
+def create_token(issuer, audience, key_id, private_key, subject=None):
+    """" returns a token based upon the supplied parameters. """
+    signer = atlassian_jwt_auth.create_signer(
+        issuer, key_id, private_key, subject=subject)
+    return signer.generate_jwt(audience)
+
+
 class BaseJWTAlgorithmTestMixin(object):
 
     """ A mixin class to make testing different support for different