Skip to content

Commit 200c024

Browse files
authored
Made small changes to loading state that gets rid of little errors (#671)
1 parent e5d070f commit 200c024

File tree

2 files changed

+43
-3
lines changed

2 files changed

+43
-3
lines changed

src/webviews/components/issue/AbstractIssueEditorPage.tsx

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,11 @@ export abstract class AbstractIssueEditorPage<
869869
onChange={(selected: any) => {
870870
this.handleSelectChange(selectField, selected);
871871
}}
872+
onMenuClose={() => {
873+
if (this.state.loadingField === field.key) {
874+
this.setState({ isSomethingLoading: false, loadingField: '' });
875+
}
876+
}}
872877
/>
873878
);
874879
}
@@ -904,6 +909,11 @@ export abstract class AbstractIssueEditorPage<
904909
this.handleSelectChange(selectField, selected);
905910
},
906911
)}
912+
onMenuClose={() => {
913+
if (this.state.loadingField === field.key) {
914+
this.setState({ isSomethingLoading: false, loadingField: '' });
915+
}
916+
}}
907917
/>
908918
{errDiv}
909919
</React.Fragment>
@@ -935,6 +945,11 @@ export abstract class AbstractIssueEditorPage<
935945
onChange={(selected: any) => {
936946
this.handleSelectChange(selectField, selected);
937947
}}
948+
onMenuClose={() => {
949+
if (this.state.loadingField === field.key) {
950+
this.setState({ isSomethingLoading: false, loadingField: '' });
951+
}
952+
}}
938953
/>
939954
);
940955
}
@@ -978,6 +993,11 @@ export abstract class AbstractIssueEditorPage<
978993
this.handleSelectChange(selectField, selected);
979994
},
980995
)}
996+
onMenuClose={() => {
997+
if (this.state.loadingField === field.key) {
998+
this.setState({ isSomethingLoading: false, loadingField: '' });
999+
}
1000+
}}
9811001
/>
9821002
{errDiv}
9831003
</React.Fragment>
@@ -1006,6 +1026,11 @@ export abstract class AbstractIssueEditorPage<
10061026
loadOptions={async (input: any) =>
10071027
await this.loadSelectOptionsForField(field as SelectFieldUI, input)
10081028
}
1029+
onMenuClose={() => {
1030+
if (this.state.loadingField === field.key) {
1031+
this.setState({ isSomethingLoading: false, loadingField: '' });
1032+
}
1033+
}}
10091034
/>
10101035
);
10111036
}
@@ -1050,6 +1075,11 @@ export abstract class AbstractIssueEditorPage<
10501075
loadOptions={async (input: any) =>
10511076
await this.loadSelectOptionsForField(field as SelectFieldUI, input)
10521077
}
1078+
onMenuClose={() => {
1079+
if (this.state.loadingField === field.key) {
1080+
this.setState({ isSomethingLoading: false, loadingField: '' });
1081+
}
1082+
}}
10531083
/>
10541084
{errDiv}
10551085
</React.Fragment>
@@ -1096,6 +1126,11 @@ export abstract class AbstractIssueEditorPage<
10961126
loadOptions={async (input: any) =>
10971127
await this.loadSelectOptionsForField(field as SelectFieldUI, input)
10981128
}
1129+
onMenuClose={() => {
1130+
if (this.state.loadingField === field.key) {
1131+
this.setState({ isSomethingLoading: false, loadingField: '' });
1132+
}
1133+
}}
10991134
></AsyncCreatableSelect>
11001135
);
11011136
}
@@ -1144,6 +1179,11 @@ export abstract class AbstractIssueEditorPage<
11441179
loadOptions={async (input: any) =>
11451180
await this.loadSelectOptionsForField(field as SelectFieldUI, input)
11461181
}
1182+
onMenuClose={() => {
1183+
if (this.state.loadingField === field.key) {
1184+
this.setState({ isSomethingLoading: false, loadingField: '' });
1185+
}
1186+
}}
11471187
></AsyncCreatableSelect>
11481188
{errDiv}
11491189
</React.Fragment>

src/webviews/components/issue/create-issue-screen/CreateIssuePage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,15 +284,15 @@ export default class CreateIssuePage extends AbstractIssueEditorPage<Emit, Accep
284284
project: newValue,
285285
fieldValues: this.state.fieldValues,
286286
});
287-
}
288-
289-
if (field.valueType === ValueType.IssueType) {
287+
} else if (field.valueType === ValueType.IssueType) {
290288
this.setState({ loadingField: field.key, isSomethingLoading: true });
291289
this.postMessage({
292290
action: 'setIssueType',
293291
issueType: newValue,
294292
fieldValues: this.state.fieldValues,
295293
});
294+
} else {
295+
this.setState({ isSomethingLoading: false, loadingField: '' });
296296
}
297297
};
298298

0 commit comments

Comments
 (0)