AXON-1972: add tests and fix typo (#1704)

Author: apeni

src/lib/webview/controller/config/configV3WebviewController.test.ts

@@ -164,6 +164,42 @@ describe('ConfigV3WebviewController', () => {
                 ...section,
             });
         });
+
+        test('should call invalidate when section is undefined', async () => {
+            const mockJiraSites = [{ id: 'site1' }];
+            const mockBBSites = [{ id: 'site2' }];
+            const mockTarget = 'workspace';
+            const mockConfig = { setting1: true };
+            const mockFeedbackUser = { id: 'user1' };
+
+            mockApi.getSitesWithAuth.mockResolvedValue([mockJiraSites, mockBBSites] as any);
+            mockApi.getConfigTarget.mockReturnValue(mockTarget as any);
+            mockApi.flattenedConfigForTarget.mockReturnValue(mockConfig as any);
+            mockApi.getFeedbackUser.mockResolvedValue(mockFeedbackUser as any);
+            mockApi.getIsRemote.mockReturnValue(false);
+            mockApi.shouldShowTunnelOption.mockReturnValue(true);
+
+            controller.update(undefined);
+
+            await new Promise(process.nextTick);
+
+            expect(mockApi.getSitesWithAuth).toHaveBeenCalledTimes(1);
+            expect(mockMessagePoster).toHaveBeenCalledWith(
+                expect.objectContaining({
+                    type: ConfigMessageType.Init,
+                }),
+            );
+        });
+
+        test('should not post SectionChange when section is undefined', () => {
+            controller.update(undefined);
+
+            expect(mockMessagePoster).not.toHaveBeenCalledWith(
+                expect.objectContaining({
+                    type: ConfigMessageType.SectionChange,
+                }),
+            );
+        });
     });
 
     describe('invalidate', () => {

src/lib/webview/controller/config/configV3WebviewController.ts

@@ -143,10 +143,10 @@ export class ConfigV3WebviewController implements WebviewController<SectionV3Cha
                 try {
                     await this.invalidate();
                 } catch (e) {
-                    this._logger.error(e, 'Error refeshing config');
+                    this._logger.error(e, 'Error refreshing config');
                     this.postMessage({
                         type: CommonMessageType.Error,
-                        reason: formatError(e, 'Error refeshing config'),
+                        reason: formatError(e, 'Error refreshing config'),
                     });
                 }
                 break;

src/lib/webview/controller/config/configWebviewController.test.ts

@@ -164,6 +164,42 @@ describe('ConfigWebviewController', () => {
                 ...section,
             });
         });
+
+        test('should call invalidate when section is undefined', async () => {
+            const mockJiraSites = [{ id: 'site1' }];
+            const mockBBSites = [{ id: 'site2' }];
+            const mockTarget = 'workspace';
+            const mockConfig = { setting1: true };
+            const mockFeedbackUser = { id: 'user1' };
+
+            mockApi.getSitesWithAuth.mockResolvedValue([mockJiraSites, mockBBSites] as any);
+            mockApi.getConfigTarget.mockReturnValue(mockTarget as any);
+            mockApi.flattenedConfigForTarget.mockReturnValue(mockConfig as any);
+            mockApi.getFeedbackUser.mockResolvedValue(mockFeedbackUser as any);
+            mockApi.getIsRemote.mockReturnValue(false);
+            mockApi.shouldShowTunnelOption.mockReturnValue(true);
+
+            controller.update(undefined);
+
+            await new Promise(process.nextTick);
+
+            expect(mockApi.getSitesWithAuth).toHaveBeenCalledTimes(1);
+            expect(mockMessagePoster).toHaveBeenCalledWith(
+                expect.objectContaining({
+                    type: ConfigMessageType.Init,
+                }),
+            );
+        });
+
+        test('should not post SectionChange when section is undefined', () => {
+            controller.update(undefined);
+
+            expect(mockMessagePoster).not.toHaveBeenCalledWith(
+                expect.objectContaining({
+                    type: ConfigMessageType.SectionChange,
+                }),
+            );
+        });
     });
 
     describe('invalidate', () => {
@@ -237,7 +273,7 @@ describe('ConfigWebviewController', () => {
 
             await controller.onMessageReceived({ type: CommonActionType.Refresh });
 
-            expect(mockLogger.error).toHaveBeenCalledWith(error, 'Error refeshing config');
+            expect(mockLogger.error).toHaveBeenCalledWith(error, 'Error refreshing config');
             expect(mockMessagePoster).toHaveBeenCalledWith({
                 type: CommonMessageType.Error,
                 reason: expect.anything(),

src/lib/webview/controller/config/configWebviewController.ts

@@ -142,10 +142,10 @@ export class ConfigWebviewController implements WebviewController<SectionChangeM
                 try {
                     await this.invalidate();
                 } catch (e) {
-                    this._logger.error(e, 'Error refeshing config');
+                    this._logger.error(e, 'Error refreshing config');
                     this.postMessage({
                         type: CommonMessageType.Error,
-                        reason: formatError(e, 'Error refeshing config'),
+                        reason: formatError(e, 'Error refreshing config'),
                     });
                 }
                 break;