AXON-1847: New onboarding flow (#1628)

* add main menu quick pick items

* start with main menu and independent jira/bitbucket

* support main menu mode and back btn for jira/bb

* feat: add rovoDevOnboardingInputManager for rovo dev token and site url flow

* refactor: remove rovo flow from onboardingQuickInputManager

* refactor: remove rovo flow from onboardingQuickInputManager

* feat: onboardingProvider

* fix: ut

* feat: quick input for api token

* fix: email step

* fix: open extension

* fix: handle site url same as auth flow

* fix: add email validation

* fix: login validation

* fix: atlassian site

* fix: inline importor

* fix: remove redundent main nav

* fix: ut mock new intro func

Author: jwang19-atlassian

src/onboarding/onboardingProvider.test.ts

@@ -47,6 +47,23 @@ jest.mock('../uriHandler/atlascodeUriHandler', () => ({
     AtlascodeUriHandler: jest.fn(),
 }));
 
+jest.mock('../rovo-dev/rovoDevAuthValidator', () => ({
+    createValidatedRovoDevAuthInfo: jest.fn(async () => ({
+        user: { id: 'id', displayName: 'name', email: 'a@b.com', avatarUrl: '' },
+        state: 'Valid',
+        username: 'a@b.com',
+        password: 'token',
+        host: 'example.atlassian.net',
+        cloudId: 'cloudId',
+    })),
+}));
+
+jest.mock('../rovo-dev/rovoDevProcessManager', () => ({
+    RovoDevProcessManager: {
+        initializeRovoDev: jest.fn(),
+    },
+}));
+
 import { ConfigurationTarget, window } from 'vscode';
 
 import { ProductBitbucket, ProductJira } from '../atlclients/authInfo';
@@ -86,9 +103,12 @@ jest.mock('../config/configuration', () => ({
 
 jest.mock('./utils', () => ({
     OnboardingStep: {
+        MainMenu: 0,
         Jira: 1,
         Bitbucket: 2,
+        RovoDev: 3,
     },
+    mainMenuQuickPickItems: jest.fn(() => []),
     onboardingQuickPickItems: jest.fn(),
 }));
 
@@ -106,6 +126,16 @@ jest.mock('./onboardingQuickInputManager', () => {
     return {
         default: jest.fn().mockImplementation(() => ({
             start: jest.fn(),
+            hide: jest.fn(),
+        })),
+    };
+});
+
+jest.mock('./rovoDevOnboardingInputManager', () => {
+    return {
+        default: jest.fn().mockImplementation(() => ({
+            start: jest.fn(),
+            hide: jest.fn(),
         })),
     };
 });
@@ -129,16 +159,18 @@ describe('OnboardingProvider', () => {
     it('should initialize with correct objects', () => {
         expect(provider).toBeDefined();
         expect(provider._analyticsClient).toBeDefined();
+        expect(provider._mainMenuQuickPickManager).toBeDefined();
         expect(provider._jiraQuickPickManager).toBeDefined();
         expect(provider._bitbucketQuickPickManager).toBeDefined();
         expect(provider._quickInputManager).toBeDefined();
+        expect(provider._rovoDevInputManager).toBeDefined();
     });
 
-    it('should show Jira onboarding quick pick on start', () => {
+    it('should show main menu onboarding quick pick on start', () => {
         provider.start();
 
         expect(Container.focus).toHaveBeenCalled();
-        expect(provider._jiraQuickPickManager.show).toHaveBeenCalled();
+        expect(provider._mainMenuQuickPickManager.show).toHaveBeenCalled();
     });
 
     it('should handle Jira quick pick accept for cloud', async () => {

src/onboarding/onboardingProvider.ts

@@ -7,20 +7,31 @@ import { BasicAuthInfo, Product, ProductBitbucket, ProductJira, SiteInfo } from
 import { configuration } from '../config/configuration';
 import { BitbucketEnabledKey, Commands, JiraEnabledKey } from '../constants';
 import { Container } from '../container';
+import { createValidatedRovoDevAuthInfo } from '../rovo-dev/rovoDevAuthValidator';
+import { RovoDevProcessManager } from '../rovo-dev/rovoDevProcessManager';
 import { EXTENSION_URL } from '../uriHandler/atlascodeUriHandler';
 import OnboardingQuickInputManager from './onboardingQuickInputManager';
 import OnboardingQuickPickManager from './onboardingQuickPickManager';
-import { OnboardingInputBoxStep, OnboardingQuickPickItem, onboardingQuickPickItems, OnboardingStep } from './utils';
+import RovoDevOnboardingInputManager, { RovoDevOnboardingSubmitArgs } from './rovoDevOnboardingInputManager';
+import {
+    mainMenuQuickPickItems,
+    OnboardingInputBoxStep,
+    OnboardingQuickPickItem,
+    onboardingQuickPickItems,
+    OnboardingStep,
+} from './utils';
 
 class OnboardingProvider {
     private id = 'atlascodeOnboardingQuickPick';
 
     private _analyticsClient: AnalyticsClient;
 
+    private _mainMenuQuickPickManager: OnboardingQuickPickManager;
     private _jiraQuickPickManager: OnboardingQuickPickManager;
     private _bitbucketQuickPickManager: OnboardingQuickPickManager;
 
     private _quickInputManager: OnboardingQuickInputManager;
+    private _rovoDevInputManager: RovoDevOnboardingInputManager;
 
     constructor() {
         this._analyticsClient = Container.analyticsClient;
@@ -32,10 +43,28 @@ class OnboardingProvider {
             this._handleServerLogin.bind(this),
         );
 
+        this._rovoDevInputManager = new RovoDevOnboardingInputManager(
+            () => this._handleBack(OnboardingStep.RovoDev),
+            (args) => this._onRovoTokenSubmit(args),
+        );
+
+        this._mainMenuQuickPickManager = new OnboardingQuickPickManager(
+            mainMenuQuickPickItems(),
+            null,
+            this._onMainMenuAccept.bind(this),
+            undefined,
+            {
+                title: 'Get started with Atlassian',
+                showBackButton: false,
+                step: OnboardingStep.MainMenu,
+            },
+        );
+
         this._jiraQuickPickManager = new OnboardingQuickPickManager(
             onboardingQuickPickItems(ProductJira),
             ProductJira,
             this._quickPickOnDidAccept.bind(this),
+            this._handleBack.bind(this),
         );
 
         this._bitbucketQuickPickManager = new OnboardingQuickPickManager(
@@ -46,10 +75,53 @@ class OnboardingProvider {
         );
     }
 
-    // --- Handle Quick Pick Accept ---
-    private async _quickPickOnDidAccept(item: OnboardingQuickPickItem, product: Product) {
+    private async _onRovoTokenSubmit(args: RovoDevOnboardingSubmitArgs): Promise<void> {
+        try {
+            const host = args.siteUrl.replace(/^https?:\/\//, '').replace(/\/$/, '');
+            const authInfo = await createValidatedRovoDevAuthInfo(host, args.email, args.token);
+            await Container.credentialManager.saveRovoDevAuthInfo(authInfo);
+            await configuration.updateEffective('rovodev.enabled', true, null, true);
+            await RovoDevProcessManager.initializeRovoDev(Container.context, true);
+            this.hideQuickPick(OnboardingStep.RovoDev);
+            await commands.executeCommand('atlascode.views.rovoDev.webView.focus');
+        } catch (error) {
+            Logger.error(error, 'Rovo Dev onboarding: failed to save credentials');
+            throw error;
+        }
+    }
+
+    // --- Handle Main Menu Accept ---
+    private _onMainMenuAccept(item: OnboardingQuickPickItem) {
         const onboardingId = item.onboardingId;
+        if (!onboardingId) {
+            return;
+        }
+        switch (onboardingId) {
+            case 'onboarding:rovo':
+                this.show(OnboardingStep.RovoDev);
+                break;
+            case 'onboarding:jira':
+                this.show(OnboardingStep.Jira);
+                break;
+            case 'onboarding:bitbucket':
+                this.show(OnboardingStep.Bitbucket);
+                break;
+            default:
+                break;
+        }
+    }
+
+    private _showRovoDevTokenSetup() {
+        this._mainMenuQuickPickManager.hide();
+        this._rovoDevInputManager.start();
+    }
 
+    // --- Handle Quick Pick Accept ---
+    private async _quickPickOnDidAccept(item: OnboardingQuickPickItem, product: Product | null) {
+        if (!product) {
+            return;
+        }
+        const onboardingId = item.onboardingId;
         if (!onboardingId) {
             return;
         }
@@ -75,52 +147,48 @@ class OnboardingProvider {
     // --- Handle Next Step ---
     private _handleNext(step: OnboardingStep) {
         if (step === OnboardingStep.Jira) {
-            // Refresh Jira explorers
             commands.executeCommand(Commands.RefreshAssignedWorkItemsExplorer);
-
             commands.executeCommand(Commands.RefreshCustomJqlExplorer);
         } else if (step === OnboardingStep.Bitbucket) {
-            // Refresh Bitbucket explorers
             commands.executeCommand(Commands.BitbucketRefreshPullRequests);
-
             commands.executeCommand(Commands.RefreshPipelines);
-            this.hideQuickPick(step);
-            return;
         } else {
             return;
         }
         Container.focus();
         this.hideQuickPick(step);
-
-        this.show(step + 1);
+        this.show(OnboardingStep.MainMenu);
     }
 
     // --- Start Onboarding ---
     start() {
         this._fireViewScreenEvent();
         Container.focus();
-
-        this.show(OnboardingStep.Jira);
+        this.show(OnboardingStep.MainMenu);
     }
 
     // --- Show QuickPick ---
     show(step: OnboardingStep) {
-        if (step === OnboardingStep.Jira) {
-            // Show Jira items
+        if (step === OnboardingStep.MainMenu) {
+            this._mainMenuQuickPickManager.show();
+        } else if (step === OnboardingStep.Jira) {
             this._jiraQuickPickManager.show();
         } else if (step === OnboardingStep.Bitbucket) {
-            // Show Bitbucket items
             this._bitbucketQuickPickManager.show();
-        } else {
-            return;
+        } else if (step === OnboardingStep.RovoDev) {
+            this._showRovoDevTokenSetup();
         }
     }
 
     hideQuickPick(step: OnboardingStep) {
-        if (step === OnboardingStep.Jira) {
+        if (step === OnboardingStep.MainMenu) {
+            this._mainMenuQuickPickManager.hide();
+        } else if (step === OnboardingStep.Jira) {
             this._jiraQuickPickManager.hide();
         } else if (step === OnboardingStep.Bitbucket) {
             this._bitbucketQuickPickManager.hide();
+        } else if (step === OnboardingStep.RovoDev) {
+            this._rovoDevInputManager.hide();
         }
     }
 
@@ -167,7 +235,7 @@ class OnboardingProvider {
 
     private _handleBack(step: OnboardingStep) {
         this.hideQuickPick(step);
-        this.show(step - 1);
+        this.show(OnboardingStep.MainMenu);
     }
 
     private _handleCloud(product: Product) {

src/onboarding/onboardingQuickInputManager.test.ts

@@ -11,6 +11,9 @@ jest.mock('vscode', () => {
         window: {
             createInputBox: jest.fn(),
         },
+        commands: {
+            executeCommand: jest.fn(),
+        },
         env: {
             openExternal: jest.fn(),
         },
@@ -35,6 +38,7 @@ const mockInputBox = (i: number) => ({
     hide: jest.fn(),
     onDidTriggerButton: jest.fn(),
     onDidAccept: jest.fn(),
+    onDidHide: jest.fn(),
 });
 
 describe('OnboardingQuickInputManager', () => {

src/onboarding/onboardingQuickInputManager.ts

@@ -43,12 +43,16 @@ class OnboardingQuickInputManager {
             input.step = i + 1;
             input.ignoreFocusOut = true;
             input.buttons = [QuickInputButtons.Back, OnboardingButtons.dismiss];
-            input.onDidTriggerButton((e) => this._quickInputOnDidTriggerButton(e, i));
-            input.onDidAccept(() => this._onDidInputAccept(i));
+            input.onDidTriggerButton((e) => this._quickInputOnDidTriggerButton(e, i as OnboardingInputBoxStep));
+            input.onDidAccept(() => this._onDidInputAccept(i as OnboardingInputBoxStep));
             return input;
         });
     }
 
+    hide() {
+        this._quickInput.forEach((input) => input.hide());
+    }
+
     start(product: Product, env: string) {
         if (!this._quickInput || this._quickInput.length === 0) {
             return;

src/onboarding/onboardingQuickPickManager.test.ts

@@ -76,8 +76,12 @@ describe('OnboardingQuickPickManager', () => {
         expect(quickPickMock.totalSteps).toBe(2);
         expect(quickPickMock.activeItems).toEqual([items[0]]);
         expect(quickPickMock.step).toBe(OnboardingStep.Jira);
-        expect(quickPickMock.buttons).toEqual([OnboardingButtons.settings, OnboardingButtons.dismiss]);
-        expect(quickPickMock.placeholder).toBe('Type to search. Select settings for advanced options.');
+        expect(quickPickMock.buttons).toEqual([
+            QuickInputButtons.Back,
+            OnboardingButtons.settings,
+            OnboardingButtons.dismiss,
+        ]);
+        expect(quickPickMock.placeholder).toBe('What would you like to do first');
         expect(quickPickMock.show).toHaveBeenCalled();
     });
 
@@ -91,7 +95,7 @@ describe('OnboardingQuickPickManager', () => {
             OnboardingButtons.settings,
             OnboardingButtons.dismiss,
         ]);
-        expect(quickPickMock.placeholder).toBe('Type to search. Select settings for advanced options.');
+        expect(quickPickMock.placeholder).toBe('What would you like to do first');
         expect(quickPickMock.show).toHaveBeenCalled();
     });