Skip to content

Commit 7a5aede

Browse files
authored
fix copy to be more concise (#438)
1 parent 2fbf2dc commit 7a5aede

File tree

3 files changed

+11
-21
lines changed

3 files changed

+11
-21
lines changed

src/onboarding/onboardingQuickPickManager.test.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,14 @@ describe('OnboardingQuickPickManager', () => {
7070
const manager = new OnboardingQuickPickManager(items, ProductJira, onAccept, onBack);
7171
manager.show();
7272

73-
expect(quickPickMock.title).toBe('Setup Jira & Bitbucket');
73+
expect(quickPickMock.title).toBe('Sign in to Jira');
7474
expect(quickPickMock.ignoreFocusOut).toBe(true);
7575
expect(quickPickMock.items).toBe(items);
7676
expect(quickPickMock.totalSteps).toBe(2);
7777
expect(quickPickMock.activeItems).toEqual([items[0]]);
7878
expect(quickPickMock.step).toBe(OnboardingStep.Jira);
7979
expect(quickPickMock.buttons).toEqual([OnboardingButtons.settings]);
80-
expect(quickPickMock.placeholder).toBe(
81-
'Select your Jira site type. For more advanced options, click on the gear button.',
82-
);
80+
expect(quickPickMock.placeholder).toBe('Type to search. Select settings for advanced options.');
8381
expect(quickPickMock.show).toHaveBeenCalled();
8482
});
8583

@@ -89,9 +87,7 @@ describe('OnboardingQuickPickManager', () => {
8987

9088
expect(quickPickMock.step).toBe(OnboardingStep.Bitbucket);
9189
expect(quickPickMock.buttons).toEqual([QuickInputButtons.Back, OnboardingButtons.settings]);
92-
expect(quickPickMock.placeholder).toBe(
93-
'Select your Bitbucket site type. For more advanced options, click on the gear button.',
94-
);
90+
expect(quickPickMock.placeholder).toBe('Type to search. Select settings for advanced options.');
9591
expect(quickPickMock.show).toHaveBeenCalled();
9692
});
9793

src/onboarding/onboardingQuickPickManager.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,23 @@ class OnboardingQuickPickManager {
4040
}
4141

4242
private _resetItems() {
43-
this._quickPick.title = 'Setup Jira & Bitbucket';
4443
this._quickPick.ignoreFocusOut = true;
4544
this._quickPick.items = this._items;
4645
this._quickPick.totalSteps = 2;
4746
this._quickPick.activeItems = [this._items[0]];
48-
47+
this._quickPick.placeholder = 'Type to search. Select settings for advanced options.';
4948
switch (this.product) {
5049
case ProductJira: {
50+
this._quickPick.title = 'Sign in to Jira';
5151
this._quickPick.step = OnboardingStep.Jira;
5252
this._quickPick.buttons = [OnboardingButtons.settings];
53-
this._quickPick.placeholder =
54-
'Select your Jira site type. For more advanced options, click on the gear button.';
53+
5554
break;
5655
}
5756
case ProductBitbucket: {
57+
this._quickPick.title = 'Sign in to Bitbucket';
5858
this._quickPick.step = OnboardingStep.Bitbucket;
5959
this._quickPick.buttons = [QuickInputButtons.Back, OnboardingButtons.settings];
60-
this._quickPick.placeholder =
61-
'Select your Bitbucket site type. For more advanced options, click on the gear button.';
6260
break;
6361
}
6462
}

src/onboarding/utils.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,18 @@ export const onboardingQuickPickItems = (product: Product) => {
77
{
88
iconPath: new ThemeIcon('cloud'),
99
label: `Sign in to ${product.name} Cloud`,
10-
description: 'For most of our users.',
11-
detail: 'The URL for accessing your site will typically be in the format mysite.atlassian.net.',
10+
detail: 'For most users - site usually ends in .atlassian.net.',
1211
onboardingId: 'onboarding:cloud',
1312
},
1413
{
1514
iconPath: new ThemeIcon('server'),
1615
label: `Sign in to ${product.name} Server`,
17-
description: 'For users with a custom site.',
18-
detail: 'The URL is usually a custom domain or IP address set up by your organization.',
16+
detail: 'For users with a custom site.',
1917
onboardingId: 'onboarding:server',
2018
},
2119
{
22-
iconPath: new ThemeIcon('debug-step-over'),
20+
iconPath: new ThemeIcon('live-share'),
2321
label: `I don't have ${product.name}`,
24-
description: 'Skip this step',
25-
detail: `You can always set up a new ${product.name} account later.`,
2622
onboardingId: 'onboarding:skip',
2723
},
2824
];
@@ -52,7 +48,7 @@ export interface OnboardingQuickPickItem extends QuickPickItem {
5248
export const OnboardingButtons: Record<string, QuickInputButton> = {
5349
settings: {
5450
iconPath: new ThemeIcon('gear'),
55-
tooltip: 'Configure in settings',
51+
tooltip: 'Settings',
5652
},
5753
createApiToken: {
5854
iconPath: new ThemeIcon('key'),

0 commit comments

Comments
 (0)