AXON-791 Removed Unused Settings in Atlascode (#699)

Migelangel04 · marcomura · web-flow · commit df643ba73ee1 · 2025-08-06T16:31:38.000-10:00
* Removed Unused Settings

* Updated change log to reflect removed settings

* Responded to PR comment about changelog

---------

Co-authored-by: Marco &lt;5818581+marcomura@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,10 +4,10 @@
 
 ## What's new in 3.8.9
 
-### Features
-
 ### Bug Fixes
 
+- Removed setting options that had no practical or business logic use.
+
 - Fixed a bug where Jira site icon is broken in create Jira issue page
 
 ## What's new in 3.8.8
diff --git a/package.json b/package.json
@@ -987,18 +987,6 @@
                     "description": "Enables showing the welcome screen when a new version is installed",
                     "scope": "window"
                 },
-                "atlascode.onlineCheckerUrls": {
-                    "type": "array",
-                    "items": {
-                        "type": "string"
-                    },
-                    "default": [
-                        "https://www.atlassian.com",
-                        "https://bitbucket.org"
-                    ],
-                    "description": "Online Checker will ping these URLs to determine online status",
-                    "scope": "window"
-                },
                 "atlascode.jira.enabled": {
                     "type": "boolean",
                     "default": true,
diff --git a/src/config/model.ts b/src/config/model.ts
@@ -10,14 +10,12 @@ export interface IConfig {
     enableCharles: boolean;
     charlesCertPath: string;
     charlesDebugOnly: boolean;
-    offlineMode: boolean;
     showWelcomeOnInstall: boolean;
     jira: JiraConfig;
     bitbucket: BitbucketConfig;
     enableUIWS: boolean;
     enableCurlLogging: boolean;
     enableHttpsTunnel: boolean;
-    onlineCheckerUrls: string[];
     helpExplorerEnabled: boolean;
 }
 
@@ -115,7 +113,6 @@ export interface BitbucketExplorer {
     nestFilesEnabled: boolean;
     refreshInterval: number;
     relatedJiraIssues: BitbucketRelatedJiraIssues;
-    relatedBitbucketIssues: BitbucketRelatedBitbucketIssues;
     notifications: BitbucketNotifications;
 }
 
@@ -194,10 +191,6 @@ const emptyRelatedJiraIssues: BitbucketRelatedJiraIssues = {
     enabled: true,
 };
 
-const emptyRelatedBitbucketIssues: BitbucketRelatedBitbucketIssues = {
-    enabled: true,
-};
-
 const emptyBitbucketNotfications: BitbucketNotifications = {
     refreshInterval: 10,
     pullRequestCreated: true,
@@ -208,7 +201,6 @@ const emptyBitbucketExplorer: BitbucketExplorer = {
     nestFilesEnabled: true,
     refreshInterval: 5,
     relatedJiraIssues: emptyRelatedJiraIssues,
-    relatedBitbucketIssues: emptyRelatedBitbucketIssues,
     notifications: emptyBitbucketNotfications,
 };
 
@@ -255,13 +247,11 @@ export const emptyConfig: IConfig = {
     enableCharles: false,
     charlesCertPath: '',
     charlesDebugOnly: false,
-    offlineMode: false,
     showWelcomeOnInstall: true,
     jira: emptyJiraConfig,
     bitbucket: emptyBitbucketConfig,
     enableUIWS: false,
     enableCurlLogging: false,
     enableHttpsTunnel: false,
-    onlineCheckerUrls: [],
     helpExplorerEnabled: true,
 };
diff --git a/src/react/atlascode/config/bitbucket/BitbucketPanel.tsx b/src/react/atlascode/config/bitbucket/BitbucketPanel.tsx
@@ -56,9 +56,6 @@ export const BitbucketPanel: React.FunctionComponent<BitbucketPanelProps> = ({
                                 relatedJiraIssues={
                                     config[`${ConfigSection.Bitbucket}.explorer.relatedJiraIssues.enabled`]
                                 }
-                                relatedBitbucketIssues={
-                                    config[`${ConfigSection.Bitbucket}.explorer.relatedBitbucketIssues.enabled`]
-                                }
                                 pullRequestCreated={
                                     config[`${ConfigSection.Bitbucket}.explorer.notifications.pullRequestCreated`]
                                 }
diff --git a/src/react/atlascode/config/bitbucket/PRExplorer.tsx b/src/react/atlascode/config/bitbucket/PRExplorer.tsx
@@ -9,7 +9,6 @@ import { ConfigControllerContext } from '../configController';
 type PRExplorerProps = {
     enabled: boolean;
     relatedJiraIssues: boolean;
-    relatedBitbucketIssues: boolean;
     pullRequestCreated: boolean;
     nestFiles: boolean;
     refreshInterval: number;
@@ -25,7 +24,7 @@ const useStyles = makeStyles(
 );
 
 export const PRExplorer: React.FunctionComponent<PRExplorerProps> = memo(
-    ({ enabled, relatedJiraIssues, relatedBitbucketIssues, pullRequestCreated, nestFiles, refreshInterval }) => {
+    ({ enabled, relatedJiraIssues, pullRequestCreated, nestFiles, refreshInterval }) => {
         const classes = useStyles();
         const controller = useContext(ConfigControllerContext);
 
@@ -88,25 +87,6 @@ export const PRExplorer: React.FunctionComponent<PRExplorerProps> = memo(
                         variant="body1"
                     />
                 </Grid>
-                <Grid item>
-                    <ToggleWithLabel
-                        control={
-                            <Switch
-                                className={classes.indent}
-                                size="small"
-                                color="primary"
-                                id="bbRelatedBitbucketIssues"
-                                value="explorer.relatedBitbucketIssues.enabled"
-                                checked={relatedBitbucketIssues}
-                                disabled={!enabled}
-                                onChange={handleChange}
-                            />
-                        }
-                        label="Show related Bitbucket issues for pull requests"
-                        spacing={1}
-                        variant="body1"
-                    />
-                </Grid>
                 <Grid item>
                     <ToggleWithLabel
                         control={
diff --git a/src/react/atlascode/config/bitbucket/subpanels/PRExplorerPanel.tsx b/src/react/atlascode/config/bitbucket/subpanels/PRExplorerPanel.tsx
@@ -11,7 +11,6 @@ import { PRExplorer } from '../PRExplorer';
 type PRExplorerPanelProps = CommonSubpanelProps & {
     enabled: boolean;
     relatedJiraIssues: boolean;
-    relatedBitbucketIssues: boolean;
     pullRequestCreated: boolean;
     nestFiles: boolean;
     refreshInterval: number;
@@ -24,7 +23,6 @@ export const PRExplorerPanel: React.FunctionComponent<PRExplorerPanelProps> = me
         onSubsectionChange,
         enabled,
         relatedJiraIssues,
-        relatedBitbucketIssues,
         pullRequestCreated,
         nestFiles,
         refreshInterval,
@@ -62,7 +60,6 @@ export const PRExplorerPanel: React.FunctionComponent<PRExplorerPanelProps> = me
                     <PRExplorer
                         enabled={enabled}
                         relatedJiraIssues={relatedJiraIssues}
-                        relatedBitbucketIssues={relatedBitbucketIssues}
                         pullRequestCreated={pullRequestCreated}
                         nestFiles={nestFiles}
                         refreshInterval={refreshInterval}
diff --git a/src/react/atlascode/config/general/Connectivity.tsx b/src/react/atlascode/config/general/Connectivity.tsx
@@ -6,65 +6,44 @@ import { ConfigControllerContext } from '../configController';
 
 type ConnectivityProps = {
     enableHttpsTunnel: boolean;
-    offlineMode: boolean;
-    onlineCheckerUrls: string[];
 };
 
-export const Connectivity: React.FunctionComponent<ConnectivityProps> = memo(
-    ({ enableHttpsTunnel, offlineMode, onlineCheckerUrls }) => {
-        const controller = useContext(ConfigControllerContext);
+export const Connectivity: React.FunctionComponent<ConnectivityProps> = memo(({ enableHttpsTunnel }) => {
+    const controller = useContext(ConfigControllerContext);
 
-        const [changes, setChanges] = useState<{ [key: string]: any }>({});
-        const handleCheckedChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
-            const changes = Object.create(null);
-            changes[`${e.target.value}`] = e.target.checked;
-            setChanges(changes);
-        }, []);
+    const [changes, setChanges] = useState<{ [key: string]: any }>({});
+    const handleCheckedChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
+        const changes = Object.create(null);
+        changes[`${e.target.value}`] = e.target.checked;
+        setChanges(changes);
+    }, []);
 
-        useEffect(() => {
-            if (Object.keys(changes).length > 0) {
-                controller.updateConfig(changes);
-                setChanges({});
-            }
-        }, [changes, controller]);
+    useEffect(() => {
+        if (Object.keys(changes).length > 0) {
+            controller.updateConfig(changes);
+            setChanges({});
+        }
+    }, [changes, controller]);
 
-        return (
-            <Grid container direction="column" spacing={3}>
-                <Grid item>
-                    <ToggleWithLabel
-                        control={
-                            <Switch
-                                size="small"
-                                color="primary"
-                                id="enableHttpsTunnel"
-                                value="enableHttpsTunnel"
-                                checked={enableHttpsTunnel}
-                                onChange={handleCheckedChange}
-                            />
-                        }
-                        label="Enable https tunneling for proxies that only have an http endpoint"
-                        spacing={1}
-                        variant="body1"
-                    />
-                </Grid>
-                <Grid item>
-                    <ToggleWithLabel
-                        control={
-                            <Switch
-                                size="small"
-                                color="primary"
-                                id="offlineMode"
-                                value="offlineMode"
-                                checked={offlineMode}
-                                onChange={handleCheckedChange}
-                            />
-                        }
-                        label="Enable offline mode if you are without an internet connection to minimize errors"
-                        spacing={1}
-                        variant="body1"
-                    />
-                </Grid>
+    return (
+        <Grid container direction="column" spacing={3}>
+            <Grid item>
+                <ToggleWithLabel
+                    control={
+                        <Switch
+                            size="small"
+                            color="primary"
+                            id="enableHttpsTunnel"
+                            value="enableHttpsTunnel"
+                            checked={enableHttpsTunnel}
+                            onChange={handleCheckedChange}
+                        />
+                    }
+                    label="Enable https tunneling for proxies that only have an http endpoint"
+                    spacing={1}
+                    variant="body1"
+                />
             </Grid>
-        );
-    },
-);
+        </Grid>
+    );
+});
diff --git a/src/react/atlascode/config/general/GeneralPanel.tsx b/src/react/atlascode/config/general/GeneralPanel.tsx
@@ -51,8 +51,6 @@ export const GeneralPanel: React.FunctionComponent<GeneralPanelProps> = ({
                                 expanded={selectedSubSections.includes(ConfigSubSection.Misc)}
                                 onSubsectionChange={onSubsectionChange}
                                 enableHttpsTunnel={config['enableHttpsTunnel']}
-                                offlineMode={config['offlineMode']}
-                                onlineCheckerUrls={config['onlineCheckerUrls']}
                             />
                         </Grid>
                         <Grid item>
diff --git a/src/react/atlascode/config/general/subpanels/GenConnectPanel.tsx b/src/react/atlascode/config/general/subpanels/GenConnectPanel.tsx
@@ -10,12 +10,10 @@ import { Connectivity } from '../Connectivity';
 
 type GenConnectPanelProps = CommonSubpanelProps & {
     enableHttpsTunnel: boolean;
-    offlineMode: boolean;
-    onlineCheckerUrls: string[];
 };
 
 export const GenConnectPanel: React.FunctionComponent<GenConnectPanelProps> = memo(
-    ({ visible, expanded, onSubsectionChange, enableHttpsTunnel, offlineMode, onlineCheckerUrls }) => {
+    ({ visible, expanded, onSubsectionChange, enableHttpsTunnel }) => {
         const [internalExpanded, setInternalExpanded] = useState(expanded);
 
         const expansionHandler = useCallback(
@@ -46,11 +44,7 @@ export const GenConnectPanel: React.FunctionComponent<GenConnectPanelProps> = me
                     <PanelSubtitle>configure general connectivity settings</PanelSubtitle>
                 </ExpansionPanelSummary>
                 <ExpansionPanelDetails>
-                    <Connectivity
-                        enableHttpsTunnel={enableHttpsTunnel}
-                        offlineMode={offlineMode}
-                        onlineCheckerUrls={onlineCheckerUrls}
-                    />
+                    <Connectivity enableHttpsTunnel={enableHttpsTunnel} />
                 </ExpansionPanelDetails>
             </ExpansionPanel>
         );

Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,6 @@ export const BitbucketPanel: React.FunctionComponent<BitbucketPanelProps> = ({`
`56`	`56`	`relatedJiraIssues={`
`57`	`57`	config[`${ConfigSection.Bitbucket}.explorer.relatedJiraIssues.enabled`]
`58`	`58`	`}`
`59`		`- relatedBitbucketIssues={`
`60`		- config[`${ConfigSection.Bitbucket}.explorer.relatedBitbucketIssues.enabled`]
`61`		`- }`
`62`	`59`	`pullRequestCreated={`
`63`	`60`	config[`${ConfigSection.Bitbucket}.explorer.notifications.pullRequestCreated`]
`64`	`61`	`}`