Applied 56 patch

Author: sn2912

src/bitbucket/bitbucket-cloud/pullRequestsOverview.ts

@@ -1,4 +1,5 @@
 import { DetailedSiteInfo } from '../../atlclients/authInfo';
+import { toISOString } from '../../react/atlascode/util/date-fns';
 import { HTTPClient } from '../httpClient';
 import { BitbucketSite, PullRequest, WorkspaceRepo } from '../model';
 import { CloudPullRequestApi } from './pullRequests';
@@ -11,6 +12,21 @@ export interface OverviewViewState {
     };
 }
 
+function updatedAfter(minUpdatedTs?: string) {
+    return (pr: PullRequest) => {
+        if (!minUpdatedTs) {
+            return true;
+        }
+
+        const updatedTsIsoString = toISOString(pr.data.updatedTs);
+        if (!updatedTsIsoString) {
+            return true;
+        }
+
+        return updatedTsIsoString > minUpdatedTs;
+    };
+}
+
 export class PullRequestsOverviewApi {
     constructor(private client: HTTPClient) {}
 
@@ -44,7 +60,11 @@ export class PullRequestsOverviewApi {
         };
     }
 
-    async getOverviewViewState(ownerSlug: string, site: DetailedSiteInfo): Promise<OverviewViewState> {
+    async getOverviewViewState(
+        ownerSlug: string,
+        site: DetailedSiteInfo,
+        minUpdatedTs: string,
+    ): Promise<OverviewViewState> {
         const fields = [
             '+pullRequests.*.author',
             '+pullRequests.*.closed_on',
@@ -74,24 +94,30 @@ export class PullRequestsOverviewApi {
             `/workspaces/${ownerSlug}/overview-view-state/?fields=${encodeURIComponent(fields)}`,
         );
 
-        const authored: PullRequest[] = data.pullRequests.authored.map((pr: any) => {
-            const bbSite = this.extractSiteFromPRData(pr, site);
-            const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
+        const authored: PullRequest[] = data.pullRequests.authored
+            .map((pr: any) => {
+                const bbSite = this.extractSiteFromPRData(pr, site);
+                const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
 
-            return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
-        });
+                return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
+            })
+            .filter(updatedAfter(minUpdatedTs));
 
-        const reviewing: PullRequest[] = data.pullRequests.reviewing.map((pr: any) => {
-            const bbSite = this.extractSiteFromPRData(pr, site);
-            const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
-            return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
-        });
+        const reviewing: PullRequest[] = data.pullRequests.reviewing
+            .map((pr: any) => {
+                const bbSite = this.extractSiteFromPRData(pr, site);
+                const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
+                return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
+            })
+            .filter(updatedAfter(minUpdatedTs));
 
-        const closed: PullRequest[] = data.pullRequests.closed.map((pr: any) => {
-            const bbSite = this.extractSiteFromPRData(pr, site);
-            const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
-            return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
-        });
+        const closed: PullRequest[] = data.pullRequests.closed
+            .map((pr: any) => {
+                const bbSite = this.extractSiteFromPRData(pr, site);
+                const workspaceRepo = this.createWorkspaceRepoFromPRData(pr, bbSite);
+                return CloudPullRequestApi.toPullRequestData(pr, bbSite, workspaceRepo);
+            })
+            .filter(updatedAfter(minUpdatedTs));
 
         const response: OverviewViewState = {
             pullRequests: {

src/bitbucket/model.ts

@@ -371,7 +371,7 @@ export interface PullRequestApi {
 }
 
 export interface PullRequestsOverviewApi {
-    getOverviewViewState(ownerSlug: string, site: DetailedSiteInfo): Promise<OverviewViewState>;
+    getOverviewViewState(ownerSlug: string, site: DetailedSiteInfo, minUpdatedTs: string): Promise<OverviewViewState>;
 }
 
 export interface RepositoriesApi {

src/config/devsphere-config/devsphereConfigReview.ts

@@ -0,0 +1,23 @@
+import { Commands } from '../../constants';
+import { executeVSCodeCommand, LifecycleFns, updateConfig } from './devsphereConfigurationManager';
+
+async function reviewSetup(): Promise<void> {
+    await Promise.all([
+        executeVSCodeCommand(Commands.BitbucketPullRequestsOverviewFocus),
+        updateConfig('workbench.editor', 'showTabs', 'single'),
+        executeVSCodeCommand('workbench.action.closePanel'),
+        executeVSCodeCommand('workbench.action.closeAuxiliaryBar'),
+    ]);
+}
+
+async function reviewTeardown(): Promise<void> {
+    await Promise.allSettled([
+        updateConfig('workbench.editor', 'showTabs', 'multiple'),
+        executeVSCodeCommand('workbench.files.action.focusFilesExplorer'),
+    ]);
+}
+
+export const reviewLifecycleFns: LifecycleFns = {
+    setup: reviewSetup,
+    shutdown: reviewTeardown,
+};

src/config/devsphere-config/devsphereConfigurationManager.ts

@@ -0,0 +1,71 @@
+import { commands, Disposable, workspace } from 'vscode';
+
+export async function executeVSCodeCommand(command: string): Promise<void> {
+    try {
+        await commands.executeCommand(command);
+    } catch (error) {
+        console.error(`Failed to execute VS Code command: ${command}`, error);
+    }
+}
+
+export async function updateConfig(section: string, key: string, value: any): Promise<void> {
+    const config = workspace.getConfiguration(section);
+    if (config.get(key) !== value) {
+        await config.update(key, value, true);
+    }
+}
+
+/**
+ * Type representing all valid view names in the application.
+ *
+ * @important When creating a new view, you must add its name to this union type
+ * and register its teardown function in the teardownFunctions map.
+ */
+export enum View {
+    Review = 'review',
+    Noop = 'noop',
+}
+
+export type LifecycleFns = {
+    setup: () => Promise<void>;
+    shutdown: () => Promise<void>;
+};
+
+export const getDefaultLifecycleFns = (): LifecycleFns => ({
+    setup: async () => {},
+    shutdown: async () => {},
+});
+
+export class DevsphereConfigurationManager implements Disposable {
+    private currentView: View = View.Noop;
+
+    constructor(private lifecycleFunctions: Record<View, LifecycleFns>) {}
+
+    dispose() {
+        this.lifecycleFunctions = {
+            [View.Noop]: getDefaultLifecycleFns(),
+            [View.Review]: getDefaultLifecycleFns(),
+        };
+    }
+
+    async setupView(view: View) {
+        if (view === this.currentView) {
+            return;
+        }
+
+        const oldView = this.currentView;
+        this.currentView = view;
+
+        try {
+            await this.lifecycleFunctions[oldView].shutdown();
+        } catch (error) {
+            console.error(`Failed to shutdown view: ${oldView}`, error);
+        }
+
+        try {
+            await this.lifecycleFunctions[view].setup();
+        } catch (error) {
+            console.error(`Failed to setup view: ${view}`, error);
+        }
+    }
+}

src/config/devsphere-config/registerDevsphereCommands.ts

@@ -0,0 +1,31 @@
+import { commands, ExtensionContext } from 'vscode';
+
+import { Commands } from '../../constants';
+import { reviewLifecycleFns } from './devsphereConfigReview';
+import {
+    DevsphereConfigurationManager,
+    getDefaultLifecycleFns,
+    LifecycleFns,
+    View,
+} from './devsphereConfigurationManager';
+
+// Map view names to their teardown functions - must include all possible ViewName values
+const lifecycleFunctions: Record<View, LifecycleFns> = {
+    [View.Review]: reviewLifecycleFns,
+    [View.Noop]: getDefaultLifecycleFns(),
+};
+
+export function registerDevsphereCommands(context: ExtensionContext): void {
+    const devsphereConfigManager = new DevsphereConfigurationManager(lifecycleFunctions);
+
+    context.subscriptions.push(devsphereConfigManager);
+
+    context.subscriptions.push(
+        commands.registerCommand(Commands.InitialiseDevsphereReviewSettings, () =>
+            devsphereConfigManager.setupView(View.Review),
+        ),
+        commands.registerCommand(Commands.ResetDevsphereCustomConfiguration, () =>
+            devsphereConfigManager.setupView(View.Noop),
+        ),
+    );
+}