Skip to content

Commit 66e3389

Browse files
authored
ARC-2061 changing all references from sample to example (#34)
1 parent 7d691c3 commit 66e3389

File tree

8 files changed

+23
-23
lines changed

8 files changed

+23
-23
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# [WIP] atlassian-connect-sample-app-node
1+
# [WIP] Atlassian Connect example app - Node edition
22

33
> **_NOTE:_** This repository is in progress and is not ready yet.
44
55
## About
6-
This repository contains a [Express](https://expressjs.com/en/4x/api.html) starter for building an [Atlassian Connect app](https://developer.atlassian.com/cloud/jira/platform/getting-started-with-connect/).
6+
This repository contains an example [Express](https://expressjs.com/en/4x/api.html) server for building an [Atlassian Connect app](https://developer.atlassian.com/cloud/jira/platform/getting-started-with-connect/).
77
This app is aimed to help you to easily add your integration in Jira.
88

99
## Table of Contents

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "@atlassian/atlassian-connect-sample-app-node",
2+
"name": "@atlassian/node-connect-example",
33
"version": "1.0.0",
4-
"repository": "[email protected]:atlassian/atlassian-connect-sample-app-node.git",
4+
"repository": "[email protected]:atlassian/atlassian-connect-example-app-node.git",
55
"license": "MIT",
66
"private": false,
77
"scripts": {

src/content/authentication.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ which also provides a comprehensive list of claims supported by Atlassian produc
131131

132132
### Atlassian JWT libraries
133133

134-
In this sample app, we use the [atlassian-jwt](https://www.npmjs.com/package/atlassian-jwt) library to create a middleware
134+
In this example app, we use the [atlassian-jwt](https://www.npmjs.com/package/atlassian-jwt) library to create a middleware
135135
called `connectIframeJWTMiddleware`, which decodes the JWT token from Jira, verifies it and sets the `clientKey` in `res.locals`.
136136
The tenant (Jira site) for each instance of the app is recognized based on this `clientKey`. Step by step,
137137
`connectIframeJWTMiddleware` is responsible for:

src/content/config.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# Atlassian Connect JSON
22

33
When you create a Connect app you'll need to include an app descriptor JSON file. This is what you'll use to
4-
provide information to Atlassian about your application, also known as an add-on. In this sample app you'll find
4+
provide information to Atlassian about your application, also known as an add-on. In this example app you'll find
55
the configuration for this in src/config/index.ts which is what we are rendering below. Included in this project's
66
app descriptor is:
77

88
- `name`: the name of the Connect app
99
- `description`: description for the Connect app
1010
- `key`: a unique key to identify your Connect app. This key must be <= 64 characters
11-
- `baseUrl`: The base url of the remote app, which is used for all communications back to the app instance. For this
12-
sample app, this is the tunneled URL which is set in the `prestart.ts`
11+
- `baseUrl`: The base url of the remote app, which is used for all communications back to the app instance. For this
12+
example app, this is the tunneled URL which is set in the `prestart.ts`
1313
- `vendor`: the vendor who is offering this Connect app
1414
- `authentication`: this defines the authentication type to use when signing requests between the host application
1515
and the Connect app. The supported types include `jwt`, `JWT`, `none`, `NONE`. We'll go into more detail around
@@ -23,14 +23,14 @@ more detail in **Lifecycle Events**
2323
- `modules`: extensions for the parts of Jira.
2424
- `postInstallPage`: this is the first page where the user lands after clicking on the `Get Started` link after
2525
installing the app. You can think of this page as the main index page for the app.
26-
- `webhooks`: list of all the webhooks for the Connect app. For this sample app, we've added some Jira webhooks
26+
- `webhooks`: list of all the webhooks for the Connect app. For this example app, we've added some Jira webhooks
2727
events. In our **Webhooks** page, we'll provide some webhook logs so you can get a better picture of what your app
2828
will be listening to
2929
- `generalPages`: list of [pages/views](https://developer.atlassian.com/cloud/jira/software/modules/page/) within the app.
3030
- `url`: the url to retrieve the content from. This must be relative to your app's baseUrl.
3131
- `key`: a key to identify this module. The key is used to generate the url to your add-on's module e.g.
3232
The node app URL `https://<TUNNELED_URL>/config` is now mapped to
33-
`https://<JIRAHOST_INSTANCE>/plugins/servlet/ac/com.atlassian.sample-app-node/acn-config`
33+
`https://<JIRAHOST_INSTANCE>/plugins/servlet/ac/com.example.node-connect-app/acn-config`
3434
- `location`: defines the location in the application interface where the page's link should appear. For finding
3535
locations, please use the linked web fragment finders for
3636
[Jira](https://marketplace.atlassian.com/apps/1211656/web-fragment-finder?hosting=cloud&tab=overview)

src/content/connect-js.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Once this has been added you'll be able to access the following features:
3737
- Request—make an XMLHttpRequest to the host product
3838
- User—obtain the user's Atlassian account ID, time zone, and locale
3939

40-
In this sample app you'll see that in our views, we're using the navigator feature to navigate from one page to the next:
40+
In this example app you'll see that in our views, we're using the navigator feature to navigate from one page to the next:
4141

4242
```
4343
document.getElementById('homePage').addEventListener('click', () => {

src/content/introduction.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Introduction
22

3-
Welcome to the Node.js Connect sample app! This sample app has been built to help you and your team get up-and-running faster
3+
Welcome to the Atlassian Connect Node.js example app! This has been built to help you and your team get up-and-running faster
44
by providing examples of the key features, functionality and things you'll need to create a
55
[Connect](https://developer.atlassian.com/cloud/bitbucket/faqs/#:~:text=Atlassian%20Connect%20is%20a%20distributed,wherever%2C%20whenever%2C%20and%20however)
6-
app. In this sample app you'll find information about the following:
6+
app. In this example app you'll find information about the following:
77

88
- [**Atlassian Connect JSON**](/acn-config): what it is, an example of an Atlassian Connect JSON file, and a link to where you can get more information
99
- [**Lifecycle Events**](/acn-lifecycle-events): outline of what lifecycle events are supported, an example of how to use them, and a link to documentation

src/env.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ if (!variables?.NGROK_AUTHTOKEN) {
1919
}
2020

2121
export const envVars: EnvVars = {
22-
APP_KEY: "com.atlassian.sample-app-node",
22+
APP_KEY: "com.example.node-connect-app",
2323
...variables
2424
} as EnvVars;

src/routes/atlassian-connect.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,31 +13,31 @@ export const connectAppDescriptor = {
1313
/**
1414
* Name of the Connect app
1515
*/
16-
name: "Atlassian Connect Sample Node App",
16+
name: "Atlassian Connect Example Node App",
1717

1818
/**
1919
* Description for the Connect app
2020
*/
21-
description: "Atlassian Connect Sample Node App",
21+
description: "Atlassian Connect Example Node App",
2222

2323
/**
2424
* A unique key to identify your Connect app. This key must be <= 64 characters.
2525
*/
2626
key: envVars.APP_KEY,
2727

2828
/**
29-
* The base url of the remote app, which is used for all communications back to the app instance.
29+
* The base url of the server, which is used for all communications between Connect and the app.
3030
*
31-
* For this sample app, this is the tunneled URL which is set in the `prestart.ts`
31+
* The tunneled URL which is set in the `prestart.ts`
3232
*/
3333
baseUrl: envVars.APP_URL,
3434

3535
/**
3636
* The vendor who is offering this Connect app.
3737
*/
3838
vendor: {
39-
name: "Node Connect app sample",
40-
url: "https://github.com/atlassian/atlassian-connect-sample-app-node/"
39+
name: "Atlassian",
40+
url: "https://atlassian.com"
4141
},
4242

4343
/**
@@ -93,7 +93,7 @@ export const connectAppDescriptor = {
9393

9494
/**
9595
* List of all the webhooks for the Connect app.
96-
* For this sample app, we've added some Jira webhooks events.
96+
* For this example, we've added some Jira webhooks events.
9797
*
9898
* https://developer.atlassian.com/cloud/jira/platform/webhooks/
9999
*/
@@ -122,7 +122,7 @@ export const connectAppDescriptor = {
122122
key: "addon-web-section",
123123
location: "admin_plugins_menu",
124124
name: {
125-
value: "Connect Sample Node App"
125+
value: "Node Connect Example App"
126126
}
127127
}
128128
],
@@ -144,7 +144,7 @@ export const connectAppDescriptor = {
144144
* The url is generated as a combination of your add-on key and module key.
145145
*
146146
* For instance:
147-
* The node app URL `https://<TUNNELED_URL>/config` is now mapped to `https://<JIRAHOST_INSTANCE>/plugins/servlet/ac/com.atlassian.sample-app-node/acn-config`
147+
* The node app URL `https://<TUNNELED_URL>/config` is now mapped to `https://<JIRAHOST_INSTANCE>/plugins/servlet/ac/com.example.node-connect-app/acn-config`
148148
*/
149149
key: "acn-config",
150150

0 commit comments

Comments
 (0)