Skip to content

Commit c49f4dd

Browse files
Merge pull request #1680 from atlassian/fix-for-logoug-confluence-9-2-0
Fix for logoug confluence 9 2 0
2 parents d4caf8f + c59ca1e commit c49f4dd

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

app/selenium_ui/confluence/modules.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,10 @@ def sub_measure():
7878

7979
def sub_measure():
8080
login_page.click_login_button()
81+
all_updates_page = AllUpdates(webdriver)
82+
all_updates_page.wait_for_page_loaded()
8183
if login_page.is_first_login():
8284
login_page.first_user_setup()
83-
all_updates_page = AllUpdates(webdriver)
8485
all_updates_page.wait_for_page_loaded()
8586
measure_dom_requests(webdriver, interaction="selenium_login:login_and_view_dashboard")
8687
if CONFLUENCE_SETTINGS.extended_metrics:
@@ -318,10 +319,13 @@ def measure():
318319

319320
def log_out(webdriver, datasets):
320321
logout_page = Logout(webdriver)
322+
login_page = Login(webdriver)
321323

322324
@print_timing("selenium_log_out")
323325
def measure():
324326
logout_page.go_to()
325327
logout_page.wait_for_logout()
328+
login_page.wait_for_page_loaded()
329+
login_page.delete_all_cookies()
326330

327331
measure()

app/selenium_ui/confluence/pages/pages.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,8 @@ def set_credentials(self, username, password):
3434
def click_login_button(self):
3535
if self.is_2sv_login:
3636
self.wait_until_visible(LoginPageLocators.login_button_2sv).click()
37-
self.wait_until_invisible(LoginPageLocators.login_button_2sv)
3837
else:
3938
self.wait_until_visible(LoginPageLocators.login_button).click()
40-
self.wait_until_invisible(LoginPageLocators.login_button)
4139

4240
def is_first_login(self):
4341
elements = self.get_elements(LoginPageLocators.first_login_setup_page)

app/selenium_ui/confluence/pages/selectors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class PopupLocators:
3535
(By.CSS_SELECTOR, ".aui-button.aui-button-link.skip-onboarding"),
3636
(By.CSS_SELECTOR, "#closeDisDialog"),
3737
(By.CSS_SELECTOR, ".aui-button.aui-button-primary.show-onboarding"),
38-
(By.CSS_SELECTOR, "button[aria-label='Close this modal']")
38+
(By.CSS_SELECTOR, 'button[aria-label="Close this modal"]')
3939
]
4040

4141

0 commit comments

Comments
 (0)