Merge pull request #172 from atlassian/jgonzalez/add_golint_ci

Add golint to CI to catch more linting errors

Author: Jacobious52

.travis.yml

@@ -15,6 +15,7 @@ go:
 before_install:
   # install goreturns for linting
   - go get -u github.com/sqs/goreturns
+  - go get -u golang.org/x/lint/golint
 
 script:
   - make lint

lint.sh

@@ -2,6 +2,9 @@
 
 # Use Goreturns as a linter to pick up spacing formatting. Return exit code 1 if there are any errors
 # Runs gofmt + goimports
-
+# go returns
 OUTPUT="$(goreturns -d -e cmd/ pkg/)"
 test -z "$OUTPUT" || ((>&2 echo -e "$OUTPUT" "\ntry running 'make fmt'") && exit 1)
+
+# golint
+golint -set_exit_status ./...

pkg/cloudprovider/aws/aws.go

@@ -349,7 +349,7 @@ func (n *NodeGroup) setASGDesiredSizeOneShot(addCount int64) error {
 			DefaultTargetCapacityType: awsapi.String("on-demand"),
 		},
 		LaunchTemplateConfigs: []*ec2.FleetLaunchTemplateConfigRequest{
-			&ec2.FleetLaunchTemplateConfigRequest{
+			{
 				LaunchTemplateSpecification: &ec2.FleetLaunchTemplateSpecificationRequest{
 					LaunchTemplateId: awsapi.String(n.config.AWSConfig.LaunchTemplateID),
 					Version:          awsapi.String(n.config.AWSConfig.LaunchTemplateVersion),
@@ -378,7 +378,7 @@ func (n *NodeGroup) setASGDesiredSizeOneShot(addCount int64) error {
 	defer ticker.Stop()
 	defer deadline.Stop()
 
-	// Escalator will block waiting for all nodes to become avaiable in this
+	// Escalator will block waiting for all nodes to become available in this
 	// node group for the maximum time specified in FleetInstanceReadyTimeout.
 	// This should typically be quite fast as it's just the time for the
 	// instance to boot and transition to ready state. The instance must be in
@@ -397,7 +397,7 @@ InstanceReadyLoop:
 
 	// The AttachInstances API only supports adding 20 instances at a time
 	batchSize := 20
-	batch := make([]*string, batchSize)
+	var batch []*string
 	for batchSize < len(instances) {
 		instances, batch = instances[batchSize:], instances[0:batchSize:batchSize]
 

pkg/test/aws.go

@@ -8,7 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go/service/ec2/ec2iface"
 )
 
-// MockAutoscalingService is a mock implentation of a cloud provider interface
+// MockAutoscalingService is a mock implementation of a cloud provider interface
 type MockAutoscalingService struct {
 	autoscalingiface.AutoScalingAPI
 	*client.Client