small fix for better dev experience (#49)

* small fix for better dev experience

* Add CI builds back

* add eslint

Author: Noviny

.changeset/234a1cb2/changes.json

@@ -0,0 +1 @@
+{ "releases": [{ "name": "extract-react-types-loader", "type": "patch" }], "dependents": [] }

.changeset/234a1cb2/changes.md

@@ -0,0 +1 @@
+- Fix the dev mode data to align with new structure for ERT 0.15, as previously no render was occurring

.eslintignore

@@ -0,0 +1,4 @@
+# Generated files
+dist/
+node_modules/
+flow-typed/

.eslintrc.js

@@ -0,0 +1,97 @@
+module.exports = {
+  extends: [
+    'prettier',
+    'airbnb',
+    'prettier/react',
+    'plugin:jest/recommended',
+    'plugin:prettier/recommended'
+  ],
+  parser: 'babel-eslint',
+  plugins: ['prettier', 'react', 'import', 'jest'],
+  env: {
+    es6: true,
+    browser: true,
+    node: true,
+    'jest/globals': true
+  },
+  globals: {
+    // flow globals
+    TimeoutID: true,
+    IntervalID: true,
+    AnimationFrameID: true
+  },
+  rules: {
+    // Error on prettier violations
+    'prettier/prettier': 'error',
+
+    'prefer-const': 'off',
+
+    // New eslint style rules that is not disabled by prettier:
+    'lines-between-class-members': 'off',
+
+    // Allowing warning and error console logging
+    // use `invariant` and `warning`
+    'no-console': ['error'],
+
+    // Opting out of prefer destructuring (nicer with flow in lots of cases)
+    'prefer-destructuring': 'off',
+
+    // Disallowing the use of variables starting with `_` unless it called on `this`.
+    // Allowed: `this._secret = Symbol()`
+    // Not allowed: `const _secret = Symbol()`
+    'no-underscore-dangle': ['error', { allowAfterThis: true }],
+
+    // Cannot reassign function parameters but allowing modification
+    'no-param-reassign': ['error', { props: false }],
+
+    // Allowing ++ on numbers
+    'no-plusplus': 'off',
+
+    // Allowing Math.pow rather than forcing `**`
+    'no-restricted-properties': [
+      'off',
+      {
+        object: 'Math',
+        property: 'pow'
+      }
+    ],
+
+    // Allowing jsx in files with any file extension (old components have jsx but not the extension)
+    'react/jsx-filename-extension': 'off',
+
+    // Not requiring default prop declarations all the time
+    'react/require-default-props': 'off',
+
+    // Opt out of preferring stateless functions
+    'react/prefer-stateless-function': 'off',
+
+    // Allowing files to have multiple components in it
+    'react/no-multi-comp': 'off',
+
+    // Sometimes we use the PropTypes.object PropType for simplicity
+    'react/forbid-prop-types': 'off',
+
+    // Allowing the non function setState approach
+    'react/no-access-state-in-setstate': 'off',
+
+    // Opting out of this
+    'react/destructuring-assignment': 'off',
+
+    // Adding 'skipShapeProps' as the rule has issues with correctly handling PropTypes.shape
+    'react/no-unused-prop-types': ['error', { skipShapeProps: true }],
+
+    // Having issues with this rule not working correctly
+    'react/default-props-match-prop-types': 'off',
+
+    // Allowing importing from dev deps (for stories and tests)
+    'import/no-extraneous-dependencies': 'off',
+    'spaced-comment': 'off',
+    'consistent-return': 'off',
+    'no-else-return': 'off',
+    'react/jsx-curly-brace-presence': 'off',
+    'import/no-useless-path-segments': 'off',
+    'react/sort-comp': 'off',
+    'no-use-before-define': 'off',
+    'no-restricted-syntax': 'off'
+  }
+};

packages/extract-react-types/.travis.yml renamed to .travis.yml

@@ -4,6 +4,7 @@ node_js:
   - '8'
 cache: yarn
 script: |
+  yarn bolt
   yarn flow check
   if [[ $? != 0 ]]; then exit 1; fi
   yarn test

LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2019 Ben Conolly
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package.json

@@ -1,9 +1,13 @@
 {
   "name": "extract-react-types-mono-repo",
   "version": "0.0.0",
+  "license": "MIT",
   "scripts": {
     "test": "jest",
-    "changeset": "bolt build-releases changeset"
+    "changeset": "bolt build-releases changeset",
+    "dev:pretty-proptypes": "bolt w pretty-proptypes run dev",
+    "lint": "yarn eslint \"./**/*.js\"",
+    "check": "yarn lint && yarn test && yarn flow"
   },
   "bolt": {
     "workspaces": [
@@ -16,6 +20,7 @@
     "@babel/types": "^7.0.0-beta.56",
     "ast-pretty-print": "^2.0.1",
     "babel-errors": "^1.1.1",
+    "babel-eslint": "^10.0.1",
     "babel-explode-module": "^3.0.0",
     "babel-file": "^3.0.0",
     "babel-file-loader": "^2.0.0",
@@ -28,6 +33,15 @@
     "babylon": "^7.0.0-beta.22",
     "babylon-options": "^2.0.1",
     "emotion": "^9.1.1",
+    "eslint": "^5.13.0",
+    "eslint-config-airbnb": "^17.1.0",
+    "eslint-config-prettier": "^4.0.0",
+    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-jest": "^22.2.2",
+    "eslint-plugin-jsx-a11y": "^6.2.1",
+    "eslint-plugin-prettier": "^3.0.1",
+    "eslint-plugin-react": "^7.12.4",
+    "jest-in-case": "^1.0.2",
     "react-markings": "^1.2.0",
     "strip-indent": "^2.0.0"
   },

packages/extract-react-types-loader/index.js

@@ -4,37 +4,33 @@ const path = require('path');
 const extractReactTypes = require('extract-react-types');
 
 const devProps = {
-  classes: [
-    {
-      value: {
-        kind: 'object',
-        members: [
+  component: {
+    kind: 'object',
+    members: [
+      {
+        kind: 'property',
+        key: { kind: 'id', name: 'Warning' },
+        value: { kind: 'any' },
+        optional: false,
+        leadingComments: [
           {
-            kind: 'property',
-            key: { kind: 'id', name: 'Warning' },
-            value: { kind: 'any' },
-            optional: false,
-            leadingComments: [
-              {
-                type: 'commentBlock',
-                value: `extract-react-types is not being run in dev mode for speed reasons. If you need to
+            type: 'commentBlock',
+            value: `extract-react-types is not being run in dev mode for speed reasons. If you need to
 see prop types add the environment variable \`FORCE_EXTRACT_REACT_TYPES\`
 eg:
 - \`FORCE_EXTRACT_REACT_TYPES=true yarn start <packageName>\`
 - \`FORCE_EXTRACT_REACT_TYPES=true yarn start:<team>\``,
-                raw: '**',
-              },
-            ],
-            default: {
-              kind: 'string',
-              value: 'Prop types are not shown in dev mode',
-            },
-          },
+            raw: '**'
+          }
         ],
-        referenceIdName: 'AvatarPropTypes',
-      },
-    },
-  ],
+        default: {
+          kind: 'string',
+          value: 'Prop types are not shown in dev mode'
+        }
+      }
+    ],
+    referenceIdName: 'AvatarPropTypes'
+  }
 };
 
 module.exports = function extractReactTypesLoader(content /* : string */) {
@@ -51,15 +47,11 @@ module.exports = function extractReactTypesLoader(content /* : string */) {
 
   const resolveOpts = {
     pathFilter: (pkg, location, dist) => {
-      if (
-        pkg['atlaskit:src'] &&
-        location.includes('node_modules') &&
-        location.includes(pkg.main)
-      ) {
+      if (pkg['atlaskit:src'] && location.includes('node_modules') && location.includes(pkg.main)) {
         return location.replace(dist, pkg['atlaskit:src']);
       }
       return null;
-    },
+    }
   };
 
   const types = extractReactTypes(content, typeSystem, filename, resolveOpts);