Add member APIs access to Sentry

Author: irisgve

member.go

@@ -8,14 +8,15 @@ import (
 
 // Member is a sentry member
 type Member struct {
-	Email       *string    `json:"email,omitempty"`
+	Email       string     `json:"email,omitempty"`
 	Expired     *bool      `json:"expired,omitempty"`
 	Name        *string    `json:"name,omitempty"`
 	IsPending   *bool      `json:"isPending,omitempty"`
 	DateCreated *time.Time `json:"dateCreated,omitempty"`
-	Role        *string    `json:"role,omitempty"`
+	Role        string     `json:"role,omitempty"`
 	ID          *string    `json:"id,omitempty"`
 	RoleName    *string    `json:"roleName,omitempty"`
+	Teams       []string   `json:"teams,omitempty"`
 }
 
 type memberQuery struct {
@@ -28,7 +29,20 @@ func (o *memberQuery) ToQueryString() string {
 	return query.Encode()
 }
 
-// GetMember takes a user email and returns back the user
+// CreateMember takes an email and creates a new member
+func (c *Client) CreateMember(o Organization, email string) (Member, error) {
+	var member Member
+	memberRole := "member"
+	memberreq := Member{
+		Email: email,
+		Role:  memberRole,
+	}
+
+	err := c.do("POST", fmt.Sprintf("organizations/%s/members", *o.Slug), &member, &memberreq)
+	return member, err
+}
+
+// GetMemberByEmail takes a user email and returns back the user
 func (c *Client) GetMemberByEmail(o Organization, memberEmail string) (Member, error) {
 	var members []Member
 
@@ -44,15 +58,19 @@ func (c *Client) GetMemberByEmail(o Organization, memberEmail string) (Member, e
 	return members[0], err
 }
 
-// AddMemberToTeam takes a member and adds them to a team
-func (c *Client) AddMemberToTeam(o Organization, t Team, m Member) error {
+// AddExistingMemberToTeam takes a member and adds them to a team
+func (c *Client) AddExistingMemberToTeam(o Organization, t Team, m Member) error {
 	return c.do("POST", fmt.Sprintf("organizations/%s/members/%s/teams/%s", *o.Slug, *m.ID, *t.Slug), nil, nil)
 }
 
+// DeleteMember takes a member and deletes from the org
+func (c *Client) DeleteMember(o Organization, m Member) error {
+	return c.do("DELETE", fmt.Sprintf("organizations/%s/members/%s", *o.Slug, *m.ID), nil, nil)
+}
+
 // MakeAdmin takes a member and makes them admin
 func (c *Client) MakeAdmin(o Organization, a Member) error {
-	adminRole := "admin"
-	a.Role = &adminRole
+	a.Role = "admin"
 
 	return c.do("PUT", fmt.Sprintf("organizations/%s/members/%s", *o.Slug, *a.ID), nil, &a)
 }

member_test.go

@@ -0,0 +1,71 @@
+package sentry
+
+import (
+	"testing"
+)
+
+const testEmail = "[email protected]"
+
+func createMemberHelper(t *testing.T, org Organization) (Member, func() error) {
+	client := newTestClient(t)
+
+	member, err := client.CreateMember(org, testEmail)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	return member, func() error {
+		return client.DeleteMember(org, member)
+	}
+}
+
+func getMemberHelper(t *testing.T, org Organization, email string) Member {
+	client := newTestClient(t)
+
+	member, err := client.GetMemberByEmail(org, testEmail)
+	if err != nil {
+		t.Error(err)
+	}
+
+	return member
+}
+
+func TestMemberResource(t *testing.T) {
+	t.Parallel()
+
+	client := newTestClient(t)
+	org, err := client.GetOrganization(getDefaultOrg())
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	team, cleanUpTeam := createTeamHelper(t)
+	defer cleanUpTeam()
+
+	member, cleanUpMember := createMemberHelper(t, org)
+	defer cleanUpMember()
+
+	t.Run("Fetch member by email returns error if non existing member", func(t *testing.T) {
+		_, err := client.GetMemberByEmail(org, "[email protected]")
+		if err == nil {
+			t.Error("Should have returned error for non existing member")
+		}
+	})
+
+	t.Run("Add member to team", func(t *testing.T) {
+		if err := client.AddExistingMemberToTeam(org, team, member); err != nil {
+			t.Error(err)
+		}
+	})
+
+	t.Run("Make member admin", func(t *testing.T) {
+		if err := client.MakeAdmin(org, member); err != nil {
+			t.Error(err)
+		}
+
+		member := getMemberHelper(t, org, testEmail)
+		if member.Role != "admin" {
+			t.Error("Member not made admin")
+		}
+	})
+}