Merge pull request #18 from atlassian/cwood/fix-tests

Cwood/fix tests

Author: cwood

.travis.yml

@@ -1,9 +1,9 @@
 language: go
 
 go:
-  - "1.9"
   - "1.10"
   - "1.11"
+  - "1.13"
   - tip
 
 env:

events.go

@@ -70,7 +70,7 @@ type Event struct {
 	DateCreated     *time.Time              `json:"dateCreated,omitempty"`
 	DateReceived    *time.Time              `json:"dateReceived,omitempty"`
 	User            *User                   `json:"user,omitempty"`
-	Entries         *[]Entry                `json:"entries,omitempty"`
+	Entries         []Entry                 `json:"entries,omitempty"`
 	Packages        *map[string]string      `json:"packages,omitempty"`
 	SDK             *map[string]interface{} `json:"sdk,omitempty"`
 	Contexts        *map[string]interface{} `json:"contexts,omitempty"`

events_test.go

@@ -74,15 +74,27 @@ func TestEventsResource(t *testing.T) {
 				t.Error(err)
 			}
 
-			for _, entry := range *oldest.Entries {
+			if len(oldest.Entries) == 0 {
+				t.Fatal("no entries found and is nil")
+			}
+
+			for _, entry := range oldest.Entries {
 				name, inter, err := entry.GetInterface()
 				if err != nil {
 					t.Error(err)
 				}
 				t.Logf("Name: %s, Interface: %v, Error: %v", name, inter, err)
 
 				if name == "message" {
-					t.Logf("Messages: %v", *inter.(*datatype.Message).Message)
+					if inter == nil {
+						t.Error("iter message is nil")
+					}
+
+					if m := inter.(*datatype.Message); m != nil {
+						t.Logf("Messages: %v", m.Message)
+					} else {
+						t.Errorf("Message is nil %v", m)
+					}
 				}
 			}
 		})

userfeedback_test.go

@@ -45,6 +45,9 @@ func TestUserFeedbackResource(t *testing.T) {
 		issue := issues[0]
 
 		events, _, _ := client.GetIssueEvents(issue)
+		if len(events) == 0 {
+			t.Fatal("no events found")
+		}
 
 		feedback := NewUserFeedback("Colin Wood", "This is a great feature", "[email protected]", events[0].EventID)