Skip to content

Commit aa9324a

Browse files
committed
Change type definition of Issue.StatusDetails
1 parent 2fa4d83 commit aa9324a

File tree

3 files changed

+42
-30
lines changed

3 files changed

+42
-30
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.13
44

55
require (
66
github.com/certifi/gocertifi v0.0.0-20200104152315-a6d78f326758 // indirect
7-
github.com/getsentry/raven-go v0.2.0
7+
github.com/getsentry/raven-go v0.2.0 // indirect
88
github.com/getsentry/sentry-go v0.4.0
99
github.com/pkg/errors v0.9.1 // indirect
1010
)

issue.go

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -82,35 +82,35 @@ type Activity struct {
8282

8383
// Issue returns a issue found in sentry
8484
type Issue struct {
85-
Annotations *[]string `json:"annotations,omitempty"`
86-
AssignedTo *InternalUser `json:"assignedTo,omitempty"`
87-
Activity *[]Activity `json:"activity,omitempty"`
88-
Count *string `json:"count,omitempty"`
89-
Culprit *string `json:"culprit,omitempty"`
90-
FirstSeen *time.Time `json:"firstSeen,omitempty"`
91-
HasSeen *bool `json:"hasSeen,omitempty"`
92-
ID *string `json:"id,omitempty"`
93-
IsBookmarked *bool `json:"isBookmarked,omitempty"`
94-
IsPublic *bool `json:"isPublic,omitempty"`
95-
IsSubscribed *bool `json:"isSubscribed,omitempty"`
96-
LastSeen *time.Time `json:"lastSeen,omitempty"`
97-
Level *string `json:"level,omitempty"`
98-
Logger *string `json:"logger,omitempty"`
99-
Metadata *map[string]string `json:"metadata,omitempty"`
100-
NumComments *int `json:"numComments,omitempty"`
101-
Permalink *string `json:"permalink,omitempty"`
102-
Project *Project `json:"project,omitempty"`
103-
ShareID *string `json:"shareId,omitempty"`
104-
ShortID *string `json:"shortId,omitempty"`
105-
Stats *IssueStats `json:"stats,omitempty"`
106-
Status *Status `json:"status,omitempty"`
107-
StatusDetails *map[string]string `json:"statusDetails,omitempty"`
108-
SubscriptionDetails *map[string]string `json:"subscriptionDetails,omitempty"`
109-
Tags *[]IssueTag `json:"tags,omitempty"`
110-
Title *string `json:"title,omitempty"`
111-
Type *string `json:"type,omitempty"`
112-
UserCount *int `json:"userCount,omitempty"`
113-
UserReportCount *int `json:"userReportCount,omitempty"`
85+
Annotations *[]string `json:"annotations,omitempty"`
86+
AssignedTo *InternalUser `json:"assignedTo,omitempty"`
87+
Activity *[]Activity `json:"activity,omitempty"`
88+
Count *string `json:"count,omitempty"`
89+
Culprit *string `json:"culprit,omitempty"`
90+
FirstSeen *time.Time `json:"firstSeen,omitempty"`
91+
HasSeen *bool `json:"hasSeen,omitempty"`
92+
ID *string `json:"id,omitempty"`
93+
IsBookmarked *bool `json:"isBookmarked,omitempty"`
94+
IsPublic *bool `json:"isPublic,omitempty"`
95+
IsSubscribed *bool `json:"isSubscribed,omitempty"`
96+
LastSeen *time.Time `json:"lastSeen,omitempty"`
97+
Level *string `json:"level,omitempty"`
98+
Logger *string `json:"logger,omitempty"`
99+
Metadata *map[string]string `json:"metadata,omitempty"`
100+
NumComments *int `json:"numComments,omitempty"`
101+
Permalink *string `json:"permalink,omitempty"`
102+
Project *Project `json:"project,omitempty"`
103+
ShareID *string `json:"shareId,omitempty"`
104+
ShortID *string `json:"shortId,omitempty"`
105+
Stats *IssueStats `json:"stats,omitempty"`
106+
Status *Status `json:"status,omitempty"`
107+
StatusDetails *map[string]interface{} `json:"statusDetails,omitempty"`
108+
SubscriptionDetails *map[string]string `json:"subscriptionDetails,omitempty"`
109+
Tags *[]IssueTag `json:"tags,omitempty"`
110+
Title *string `json:"title,omitempty"`
111+
Type *string `json:"type,omitempty"`
112+
UserCount *int `json:"userCount,omitempty"`
113+
UserReportCount *int `json:"userReportCount,omitempty"`
114114
}
115115

116116
type issueQuery struct {

issue_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@ func TestIssueResource(t *testing.T) {
127127

128128
resolved := Resolved
129129
firstIssue.Status = &resolved
130+
firstIssue.StatusDetails = &map[string]interface{}{
131+
"inNextRelease": true,
132+
}
130133

131134
if err := client.UpdateIssue(firstIssue); err != nil {
132135
t.Error(err)
@@ -136,6 +139,15 @@ func TestIssueResource(t *testing.T) {
136139
t.Error("Status did not get updated")
137140
}
138141

142+
details, ok := (*firstIssue.StatusDetails)["inNextRelease"].(bool)
143+
if !ok {
144+
t.Error("Status did not get updated")
145+
}
146+
147+
if !details {
148+
t.Error("Status did not get updated")
149+
}
150+
139151
t.Run("Delete the first issue in this project", func(t *testing.T) {
140152
err := client.DeleteIssue(firstIssue)
141153
if err != nil {

0 commit comments

Comments
 (0)