fix: more strict tsconfig

aminya · aminya · commit df4ecdd18597 · 2021-07-15T00:28:35.000-05:00
diff --git a/src/CodeFormatManager.ts b/src/CodeFormatManager.ts
@@ -1,4 +1,4 @@
-import type { Point, TextEditor, TextChange, Disposable } from "atom"
+import type { TextEditor, TextChange, Disposable } from "atom"
 // TODO add to @types/atom
 type AggregatedTextChange = {
   changes: Array<TextChange>
@@ -173,7 +173,7 @@ export default class CodeFormatManager {
             return Observable.of(firstNonNull)
           }
         })
-        .map(({ _, formatted }) => {
+        .map(({ formatted }) => {
           return [
             {
               oldRange: editor.getBuffer().getRange(),
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,13 +1,13 @@
 {
   "compilerOptions": {
-    "strict": false,
-    "strictNullChecks": false,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
-    "noImplicitReturns": false,
+    "strict": true,
+    "strictNullChecks": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true,
     "noImplicitAny": false,
-    "noImplicitThis": false,
-    "noFallthroughCasesInSwitch": false,
+    "noImplicitThis": true,
+    "noFallthroughCasesInSwitch": true,
     "declaration": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { Point, TextEditor, TextChange, Disposable } from "atom"`
	`1`	`+import type { TextEditor, TextChange, Disposable } from "atom"`
`2`	`2`	`// TODO add to @types/atom`
`3`	`3`	`type AggregatedTextChange = {`
`4`	`4`	`changes: Array<TextChange>`
`@@ -173,7 +173,7 @@ export default class CodeFormatManager {`
`173`	`173`	`return Observable.of(firstNonNull)`
`174`	`174`	`}`
`175`	`175`	`})`
`176`		`- .map(({ _, formatted }) => {`
	`176`	`+ .map(({ formatted }) => {`
`177`	`177`	`return [`
`178`	`178`	`{`
`179`	`179`	`oldRange: editor.getBuffer().getRange(),`