Skip to content

Commit 2aa61c9

Browse files
committed
perf: remove config for hover animation
BREAKING this removes the config for hover animation
1 parent 487e0fb commit 2aa61c9

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

lib/config.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,5 @@
1616
"description": "The time that the mouse/cursor should hover/stay to show a datatip. Also specifies the time that the datatip is still shown when the mouse/cursor moves [ms].",
1717
"type": "number",
1818
"default": 100
19-
},
20-
"glowOnHover": {
21-
"title": "Glow on hover",
22-
"description": "Should the datatip glow when you hover on it?",
23-
"type": "boolean",
24-
"default": true
2519
}
2620
}

lib/datatip-manager.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ export class DataTipManager {
7979
/** The time that the mouse/cursor should hover/stay to show a datatip. Also specifies the time that the datatip is still shown when the mouse/cursor moves [ms]. */
8080
hoverTime = atom.config.get("atom-ide-datatip.hoverTime")
8181

82-
// glow on hover
83-
glowClass = atom.config.get("atom-ide-datatip.glowOnHover") ? "datatip-glow" : ""
84-
8582
constructor() {
8683
/**
8784
* the mouse move event handler that evaluates the screen position and eventually shows a data tip
@@ -371,7 +368,7 @@ export class DataTipManager {
371368
containerClassName: "datatip-component-container",
372369
contentClassName: "datatip-component",
373370
},
374-
className: `datatip-element select-list popover-list ${this.glowClass}`,
371+
className: "datatip-element select-list popover-list datatip-transform",
375372
})
376373
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView)
377374
} else if (datatip.markedStrings.length > 0) {
@@ -409,7 +406,7 @@ export class DataTipManager {
409406
const dataTipView = new ViewContainer({
410407
snippet,
411408
markdown,
412-
className: `datatip-element select-list popover-list ${this.glowClass}`,
409+
className: "datatip-element select-list popover-list datatip-transform",
413410
})
414411

415412
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView)

styles/atom-ide-datatips.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
width: auto;
3939
}
4040

41-
.datatip-element.datatip-glow {
41+
.datatip-element.datatip-transform {
4242
// glow on hover
4343
transition: background-color 0.15s ease;
4444
&:hover {

0 commit comments

Comments
 (0)