fix: refactor overlayFocusFix

Author: aminya

lib/datatip-manager.ts

@@ -478,6 +478,7 @@ export class DataTipManager {
 
     // makes the text selectable with the help of user-select: text
     element.setAttribute("tabindex", "-1")
+    overlayFocusFix(editor, element)
 
     editor.decorateMarker(overlayMarker, {
       type: "overlay",
@@ -487,7 +488,6 @@ export class DataTipManager {
     })
     disposables.add(new Disposable(() => overlayMarker.destroy()))
 
-    const editorComponent = atom.views.getView(editor).getComponent()
 
     element.addEventListener("mouseenter", () => {
       this.editorView?.removeEventListener("mousemove", this.onMouseMoveEvt)
@@ -499,17 +499,6 @@ export class DataTipManager {
       element.removeEventListener("keydown", copyListener)
     })
 
-    /**
-      - focus on the datatip once the text is selected (cursor gets disabled temporarily)
-      - remove focus once mouse leaves
-    */
-    element.addEventListener("mousedown", () => {
-      blurEditor(editorComponent)
-      element.addEventListener("mouseleave", () => {
-        focusEditor(editorComponent)
-      })
-    })
-
     // TODO move this code to atom-ide-base
     element.addEventListener("wheel", this.onMouseWheel, { passive: true })
 
@@ -533,6 +522,21 @@ export class DataTipManager {
   }
 }
 
+function overlayFocusFix(editor: TextEditor, element: HTMLElement) {
+  const editorComponent = atom.views.getView(editor).getComponent()
+  /**
+    - focus on the datatip once the text is selected (cursor gets disabled temporarily)
+    - remove focus once mouse leaves
+  */
+  element.addEventListener("mousedown", () => {
+    blurEditor(editorComponent)
+    element.addEventListener("mouseleave", () => {
+      focusEditor(editorComponent)
+    })
+  })
+
+}
+
 // TODO we should not need this
 /** A manual copy listener */
 async function copyListener(event: KeyboardEvent) {