Skip to content

Commit c354bd9

Browse files
committed
fix: datatips were shown on mouse move even when disabled in the configs
1 parent f230f6b commit c354bd9

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

lib/datatip-manager.ts

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -487,24 +487,26 @@ export class DataTipManager {
487487
})
488488
disposables.add(new Disposable(() => overlayMarker.destroy()))
489489

490-
element.addEventListener("mouseenter", () => {
491-
this.editorView?.removeEventListener("mousemove", this.onMouseMoveEvt)
492-
})
490+
if (this.showDataTipOnMouseMove) {
491+
element.addEventListener("mouseenter", () => {
492+
this.editorView?.removeEventListener("mousemove", this.onMouseMoveEvt)
493+
})
493494

494-
element.addEventListener("mouseleave", () => {
495-
this.editorView?.addEventListener("mousemove", this.onMouseMoveEvt)
496-
})
495+
element.addEventListener("mouseleave", () => {
496+
this.editorView?.addEventListener("mousemove", this.onMouseMoveEvt)
497+
})
498+
499+
disposables.add(
500+
new Disposable(() => {
501+
this.editorView?.addEventListener("mousemove", this.onMouseMoveEvt)
502+
view.destroy()
503+
})
504+
)
505+
}
497506

498507
// TODO move this code to atom-ide-base
499508
element.addEventListener("wheel", this.onMouseWheel, { passive: true })
500509

501-
disposables.add(
502-
new Disposable(() => {
503-
this.editorView?.addEventListener("mousemove", this.onMouseMoveEvt)
504-
view.destroy()
505-
})
506-
)
507-
508510
return disposables
509511
}
510512

0 commit comments

Comments
 (0)