Merge pull request #39 from UziTech/patch-1

Author: aminya

lib/goToDefinition.js

@@ -49,6 +49,9 @@ export async function getDefinitions(
   const position = targetPosition || editor.getCursorBufferPosition();
 
   const provider = providerRegistry.getProviderForEditor(editor);
+  if (!provider) {
+    return;
+  }
   const result = await provider.getDefinition(editor, position);
 
   return result && result.definitions;

lib/main.js

@@ -36,5 +36,5 @@ export function consumeDefinitionsService(provider) {
 }
 
 export function getClickProvider() {
-  return clickProvider.getProvider;
+  return clickProvider.getProvider();
 }

spec/go-to-definition-spec.js

@@ -0,0 +1,20 @@
+/** @babel */
+
+import { getDefinitions } from "../lib/goToDefinition";
+
+// Use the command `window:run-package-specs` (cmd-alt-ctrl-p) to run specs.
+//
+// To run a specific `it` or `describe` block add an `f` to the front (e.g. `fit`
+// or `fdescribe`). Remove the `f` to unfocus the block.
+
+describe("go to definition", () => {
+  describe("getDefinitions", () => {
+    it("returns undefined if no provider exists for editor", async () => {
+      const providerRegistry = {
+        getProviderForEditor() {}
+      }
+      const definitions = await getDefinitions(providerRegistry, { editor: true, position: true });
+      expect(definitions).toBeUndefined();
+    });
+  });
+});

spec/main-spec.js

@@ -0,0 +1,26 @@
+/** @babel */
+
+import * as main from "../lib/main";
+
+// Use the command `window:run-package-specs` (cmd-alt-ctrl-p) to run specs.
+//
+// To run a specific `it` or `describe` block add an `f` to the front (e.g. `fit`
+// or `fdescribe`). Remove the `f` to unfocus the block.
+
+describe("main", () => {
+  it("activate", async function () {
+    // Trigger deferred activation
+    atom.packages.triggerDeferredActivationHooks();
+    // Activate activation hook
+    atom.packages.triggerActivationHook("core:loaded-shell-environment");
+
+    await atom.packages.activatePackage("atom-ide-definitions");
+    expect(atom.packages.isPackageLoaded("atom-ide-definitions")).toBeTruthy();
+  });
+
+  it("getClickProvider", () => {
+    const provider = main.getClickProvider();
+
+    expect(typeof provider.getSuggestionForWord).toEqual("function");
+  });
+});