Merge pull request #165 from atom-community/this-bind

fix: determineProjectPath was called with the wrong `this`

Author: aminya

lib/auto-languageclient.ts

@@ -315,7 +315,7 @@ export default class AutoLanguageClient {
       (filepath) => this.filterChangeWatchedFiles(filepath),
       this.reportBusyWhile,
       this.getServerName(),
-      this.determineProjectPath,
+      (textEditor: TextEditor) => this.determineProjectPath(textEditor),
       this.shutdownGracefully
     )
     this._serverManager.startListening()

test/auto-languageclient.test.ts

@@ -47,8 +47,10 @@ describe("AutoLanguageClient", () => {
       // "returns null when a single file is open"
 
       let textEditor = (await atom.workspace.open(__filename)) as TextEditor
-      /* eslint-disable-next-line dot-notation */
+      /* eslint-disable dot-notation */
       expect(client["determineProjectPath"](textEditor)).toBeNull()
+      expect(serverManager["_determineProjectPath"](textEditor)).toBeNull()
+      /* eslint-enable dot-notation */
       textEditor.destroy()
 
       // "returns the project path when a file of that project is open"
@@ -59,8 +61,10 @@ describe("AutoLanguageClient", () => {
       await serverManager.startServer(projectPath)
 
       textEditor = (await atom.workspace.open(__filename)) as TextEditor
-      /* eslint-disable-next-line dot-notation */
+      /* eslint-disable dot-notation */
       expect(client["determineProjectPath"](textEditor)).toBe(normalizePath(projectPath))
+      expect(serverManager["_determineProjectPath"](textEditor)).toBe(normalizePath(projectPath))
+      /* eslint-enable dot-notation */
       textEditor.destroy()
 
       // "returns the project path when an external file is open and it is not in additional paths"
@@ -73,8 +77,10 @@ describe("AutoLanguageClient", () => {
       await serverManager.startServer(projectPath)
 
       textEditor = (await atom.workspace.open(externalFile)) as TextEditor
-      /* eslint-disable-next-line dot-notation */
+      /* eslint-disable dot-notation */
       expect(client["determineProjectPath"](textEditor)).toBeNull()
+      expect(serverManager["_determineProjectPath"](textEditor)).toBeNull()
+      /* eslint-enable dot-notation */
       textEditor.destroy()
 
       // "returns the project path when an external file is open and it is in additional paths"
@@ -87,8 +93,10 @@ describe("AutoLanguageClient", () => {
       expect(server.additionalPaths?.has(externalDir)).toBeTrue()
 
       textEditor = (await atom.workspace.open(externalFile)) as TextEditor
-      /* eslint-disable-next-line dot-notation */
+      /* eslint-disable dot-notation */
       expect(client["determineProjectPath"](textEditor)).toBe(normalizePath(projectPath))
+      expect(serverManager["_determineProjectPath"](textEditor)).toBe(normalizePath(projectPath))
+      /* eslint-enable dot-notation */
       textEditor.destroy()
     })
   })