chore: add TODO for checking the type of d.targetRange.start [skip ci]

aminya · aminya · commit 37a93982af41 · 2021-04-17T02:32:14.000-05:00
diff --git a/lib/adapters/definition-adapter.ts b/lib/adapters/definition-adapter.ts
@@ -72,8 +72,10 @@ export default class DefinitionAdapter {
     locationResult: Location | Location[] | LocationLink[] | null
   ): Location[] | LocationLink[] | null {
     if (locationResult == null) {
+      // TODO use ===
       return null
     }
+    // TODO `d.targetRange.start` never becomes `null` according to the types
     if (isLocationLinkArray(locationResult)) {
       return locationResult.filter((d) => d.targetRange.start != null)
     }

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,10 @@ export default class DefinitionAdapter {`
`72`	`72`	`locationResult: Location \| Location[] \| LocationLink[] \| null`
`73`	`73`	`): Location[] \| LocationLink[] \| null {`
`74`	`74`	`if (locationResult == null) {`
	`75`	`+ // TODO use ===`
`75`	`76`	`return null`
`76`	`77`	`}`
	`78`	+ // TODO `d.targetRange.start` never becomes `null` according to the types
`77`	`79`	`if (isLocationLinkArray(locationResult)) {`
`78`	`80`	`return locationResult.filter((d) => d.targetRange.start != null)`
`79`	`81`	`}`