fix: use free functions instead of static methods

Author: aminya

lib/adapters/show-document-adapter.ts

@@ -4,38 +4,47 @@ import { TextEditor } from "atom"
 import Convert from "../convert"
 
 /** Public: Adapts the window/showDocument command to Atom's text editors or external programs. */
-export default class ShowDocumentAdapter {
-  /**
-   * Public: Attach to a {LanguageClientConnection} to recieve requests to show documents.
-   */
-  public static attach(connection: LanguageClientConnection): void {
-    connection.onShowDocument(ShowDocumentAdapter.onShowDocument)
+export class ShowDocumentAdapter {
+  /** {@inheritDoc attach} */
+  public attach(arg: Parameters<typeof attach>[0]): ReturnType<typeof attach> {
+    attach(arg)
   }
+  /** {@inheritDoc onShowDocument} */
+  public onShowDocument(...args: Parameters<typeof onShowDocument>): ReturnType<typeof onShowDocument> {
+    return onShowDocument(...args)
+  }
+}
+
+/**
+ * Public: Attach to a {LanguageClientConnection} to recieve requests to show documents.
+ */
+export function attach(connection: LanguageClientConnection): void {
+  connection.onShowDocument(onShowDocument)
+}
 
-  /**
-   * Public: Show a notification message with buttons using the Atom notifications API.
-   *
-   * @param params The {ShowDocumentParams} received from the language server
-   *   indicating the document to be displayed as well as other metadata.
-   */
-  public static async onShowDocument(params: ShowDocumentParams): Promise<ShowDocumentResult> {
-    if (!params.external) {
-      // open using atom.workspace
-      const view = await atom.workspace.open(params.uri, {
-        activateItem: params.takeFocus,
-        activatePane: params.takeFocus,
-        pending: true,
-        initialLine: params.selection?.start.line ?? 0,
-        initialColumn: params.selection?.start.character ?? 0,
-      })
-      if (view instanceof TextEditor && params.selection != null) {
-        view.selectToBufferPosition(Convert.positionToPoint(params.selection.end))
-      }
-      return { success: true }
-    } else {
-      // open using Electron
-      shell.openExternal(params.uri, { activate: params.takeFocus })
-      return { success: true }
+/**
+ * Public: Show a notification message with buttons using the Atom notifications API.
+ *
+ * @param params The {ShowDocumentParams} received from the language server
+ *   indicating the document to be displayed as well as other metadata.
+ */
+export async function onShowDocument(params: ShowDocumentParams): Promise<ShowDocumentResult> {
+  if (!params.external) {
+    // open using atom.workspace
+    const view = await atom.workspace.open(params.uri, {
+      activateItem: params.takeFocus,
+      activatePane: params.takeFocus,
+      pending: true,
+      initialLine: params.selection?.start.line ?? 0,
+      initialColumn: params.selection?.start.character ?? 0,
+    })
+    if (view instanceof TextEditor && params.selection != null) {
+      view.selectToBufferPosition(Convert.positionToPoint(params.selection.end))
     }
+    return { success: true }
+  } else {
+    // open using Electron
+    shell.openExternal(params.uri, { activate: params.takeFocus })
+    return { success: true }
   }
 }

lib/auto-languageclient.ts

@@ -21,7 +21,7 @@ import NotificationsAdapter from "./adapters/notifications-adapter"
 import OutlineViewAdapter from "./adapters/outline-view-adapter"
 import RenameAdapter from "./adapters/rename-adapter"
 import SignatureHelpAdapter from "./adapters/signature-help-adapter"
-import ShowDocumentAdapter from "./adapters/show-document-adapter"
+import * as ShowDocumentAdapter from "./adapters/show-document-adapter"
 import * as Utils from "./utils"
 import { Socket } from "net"
 import { LanguageClientConnection } from "./languageclient"