fix: move adding completionItem to applyCompletionItemToSuggestion

aminya · aminya · commit 3c46aa197bfa · 2021-06-13T14:43:36.000-05:00
diff --git a/lib/adapters/autocomplete-adapter.ts b/lib/adapters/autocomplete-adapter.ts
@@ -422,8 +422,6 @@ export default class AutocompleteAdapter {
       onDidConvertCompletionItem(item, suggestion as ac.AnySuggestion, request)
     }
 
-    suggestion.completionItem = item
-
     return suggestion
   }
 
@@ -440,6 +438,7 @@ export default class AutocompleteAdapter {
     suggestion.displayText = item.label
     suggestion.type = AutocompleteAdapter.completionKindToSuggestionType(item.kind)
     AutocompleteAdapter.applyDetailsToSuggestion(item, suggestion)
+    suggestion.completionItem = item
   }
 
   public static applyDetailsToSuggestion(item: CompletionItem, suggestion: Suggestion): void {

Original file line number	Diff line number	Diff line change
`@@ -422,8 +422,6 @@ export default class AutocompleteAdapter {`
`422`	`422`	`onDidConvertCompletionItem(item, suggestion as ac.AnySuggestion, request)`
`423`	`423`	`}`
`424`	`424`
`425`		`- suggestion.completionItem = item`
`426`		`-`
`427`	`425`	`return suggestion`
`428`	`426`	`}`
`429`	`427`
`@@ -440,6 +438,7 @@ export default class AutocompleteAdapter {`
`440`	`438`	`suggestion.displayText = item.label`
`441`	`439`	`suggestion.type = AutocompleteAdapter.completionKindToSuggestionType(item.kind)`
`442`	`440`	`AutocompleteAdapter.applyDetailsToSuggestion(item, suggestion)`
	`441`	`+ suggestion.completionItem = item`
`443`	`442`	`}`
`444`	`443`
`445`	`444`	`public static applyDetailsToSuggestion(item: CompletionItem, suggestion: Suggestion): void {`