chore: keep getCodeActions null-safe

aminya · aminya · commit 88f11932f386 · 2021-05-01T05:00:58.000-05:00
diff --git a/lib/adapters/code-action-adapter.ts b/lib/adapters/code-action-adapter.ts
@@ -39,7 +39,7 @@ export default class CodeActionAdapter {
     editor: TextEditor,
     range: Range,
     diagnostics: atomIde.Diagnostic[]
-  ): Promise<atomIde.CodeAction[] | null> {
+  ): Promise<atomIde.CodeAction[]> {
     if (linterAdapter == null) {
       return []
     }
@@ -48,7 +48,7 @@ export default class CodeActionAdapter {
     const params = CodeActionAdapter.createCodeActionParams(linterAdapter, editor, range, diagnostics)
     const actions = await connection.codeAction(params)
     if (!actions) {
-      return null
+      return []
     }
     return actions.map((action) => CodeActionAdapter.createCodeAction(action, connection))
   }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ export default class CodeActionAdapter {`
`39`	`39`	`editor: TextEditor,`
`40`	`40`	`range: Range,`
`41`	`41`	`diagnostics: atomIde.Diagnostic[]`
`42`		`- ): Promise<atomIde.CodeAction[] \| null> {`
	`42`	`+ ): Promise<atomIde.CodeAction[]> {`
`43`	`43`	`if (linterAdapter == null) {`
`44`	`44`	`return []`
`45`	`45`	`}`
`@@ -48,7 +48,7 @@ export default class CodeActionAdapter {`
`48`	`48`	`const params = CodeActionAdapter.createCodeActionParams(linterAdapter, editor, range, diagnostics)`
`49`	`49`	`const actions = await connection.codeAction(params)`
`50`	`50`	`if (!actions) {`
`51`		`- return null`
	`51`	`+ return []`
`52`	`52`	`}`
`53`	`53`	`return actions.map((action) => CodeActionAdapter.createCodeAction(action, connection))`
`54`	`54`	`}`