chore: import signature help types from atom-ide-base

Author: aminya

lib/adapters/signature-help-adapter.ts

@@ -1,4 +1,4 @@
-import * as atomIde from 'atom-ide';
+import type { SignatureHelpRegistry } from "atom-ide-base";
 import assert = require('assert');
 import Convert from '../convert';
 import { ActiveServer } from '../server-manager';
@@ -37,7 +37,7 @@ export default class SignatureHelpAdapter {
     this._disposables.dispose();
   }
 
-  public attach(register: atomIde.SignatureHelpRegistry): void {
+  public attach(register: SignatureHelpRegistry): void {
     const { signatureHelpProvider } = this._capabilities;
     assert(signatureHelpProvider != null);
 

lib/auto-languageclient.ts

@@ -3,7 +3,7 @@ import * as ls from './languageclient';
 import * as rpc from 'vscode-jsonrpc';
 import * as path from 'path';
 import * as atomIde from 'atom-ide';
-import type { OutlineProvider, Outline, DefinitionProvider, DefinitionQueryResult, FindReferencesProvider, FindReferencesReturn, Datatip, DatatipService, TextEdit, RangeCodeFormatProvider, FileCodeFormatProvider, OnSaveCodeFormatProvider, OnTypeCodeFormatProvider, CodeAction, CodeHighlightProvider, CodeActionProvider, Diagnostic, RefactorProvider, BusySignalService } from 'atom-ide-base';
+import type { OutlineProvider, Outline, DefinitionProvider, DefinitionQueryResult, FindReferencesProvider, FindReferencesReturn, Datatip, DatatipService, TextEdit, RangeCodeFormatProvider, FileCodeFormatProvider, OnSaveCodeFormatProvider, OnTypeCodeFormatProvider, CodeAction, CodeHighlightProvider, CodeActionProvider, Diagnostic, RefactorProvider, BusySignalService, SignatureHelpRegistry } from 'atom-ide-base';
 import * as linter from 'atom/linter';
 import Convert from './convert.js';
 import ApplyEditAdapter from './adapters/apply-edit-adapter';
@@ -66,7 +66,7 @@ export default class AutoLanguageClient {
   private _serverManager!: ServerManager;
   private _consoleDelegate?: atomIde.ConsoleService;
   private _linterDelegate?: linter.IndieDelegate;
-  private _signatureHelpRegistry?: atomIde.SignatureHelpRegistry;
+  private _signatureHelpRegistry?: SignatureHelpRegistry;
   private _lastAutocompleteRequest?: ac.SuggestionsRequestedEvent;
   private _isDeactivating: boolean = false;
   private _serverAdapters = new WeakMap<ActiveServer, ServerAdapters>();
@@ -788,7 +788,7 @@ export default class AutoLanguageClient {
     );
   }
 
-  public consumeSignatureHelp(registry: atomIde.SignatureHelpRegistry): Disposable {
+  public consumeSignatureHelp(registry: SignatureHelpRegistry): Disposable {
     this._signatureHelpRegistry = registry;
     for (const server of this._serverManager.getActiveServers()) {
       const signatureHelpAdapter = this.getServerAdapter(server, 'signatureHelpAdapter');

typings/atom-ide/index.d.ts

@@ -1,61 +1,8 @@
 declare module 'atom-ide' {
-  import { Disposable, Point, TextEditor } from 'atom';
   import * as ac from 'atom/autocomplete-plus';
 
   export type IdeUri = string;
 
-  export type SignatureHelpRegistry = (provider: SignatureHelpProvider) => Disposable;
-
-  /**
-   * Signature help is activated when:
-   * - upon keystroke, any provider with a matching grammar scope contains
-   *   the pressed key inside its triggerCharacters set
-   * - the signature-help:show command is manually activated
-   *
-   * Once signature help has been triggered, the provider will be queried immediately
-   * with the current cursor position, and then repeatedly upon cursor movements
-   * until a null/empty signature is returned.
-   *
-   * Returned signatures will be displayed in a small datatip at the current cursor.
-   * The highest-priority provider with a non-null result will be used.
-   */
-  export interface SignatureHelpProvider {
-    priority: number;
-    grammarScopes: string[];
-
-    /**
-     * A set of characters that will trigger signature help when typed.
-     * If a null/empty set is provided, only manual activation of the command works.
-     */
-    triggerCharacters?: Set<string>;
-
-    getSignatureHelp(editor: TextEditor, point: Point): Promise<SignatureHelp | null>;
-  }
-
-  export interface SignatureHelp {
-    signatures: SignatureInformation[];
-    activeSignature: number | null;
-    activeParameter: number | null;
-  }
-
-  export interface SignatureInformation {
-    label: string;
-    documentation?: string | MarkupContent;
-    parameters?: ParameterInformation[];
-  }
-
-  export interface MarkupContent {
-      kind: MarkupKind;
-      value: string;
-  }
-
-  export type MarkupKind = 'plaintext' | 'markdown';
-
-  export interface ParameterInformation {
-    label: string | [number, number];
-    documentation?: string | MarkupContent;
-  }
-
   export interface SourceInfo {
     id: string;
     name: string;