fix: params.selection can be undefined

aminya · aminya · commit 921613b491dc · 2021-03-16T21:06:47.000-05:00
diff --git a/lib/adapters/show-document-adapter.ts b/lib/adapters/show-document-adapter.ts
@@ -40,7 +40,7 @@ export async function onShowDocument(params: ShowDocumentParams): Promise<ShowDo
       initialLine: params.selection?.start.line ?? 0,
       initialColumn: params.selection?.start.character ?? 0,
     })
-    if (view instanceof TextEditor && params.selection != null) {
+    if (view instanceof TextEditor && params.selection !== undefined) {
       view.selectToBufferPosition(Convert.positionToPoint(params.selection.end))
     }
     return { success: true }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export async function onShowDocument(params: ShowDocumentParams): Promise<ShowDo`
`40`	`40`	`initialLine: params.selection?.start.line ?? 0,`
`41`	`41`	`initialColumn: params.selection?.start.character ?? 0,`
`42`	`42`	`})`
`43`		`- if (view instanceof TextEditor && params.selection != null) {`
	`43`	`+ if (view instanceof TextEditor && params.selection !== undefined) {`
`44`	`44`	`view.selectToBufferPosition(Convert.positionToPoint(params.selection.end))`
`45`	`45`	`}`
`46`	`46`	`return { success: true }`