fix: autocomplete-extended types

- Using relative path ensures that the types are included in the build

- This removes the interanl types from atom-ide module

Author: aminya

lib/adapters/autocomplete-adapter.ts

@@ -20,7 +20,7 @@ import {
   TextEditor,
 } from 'atom';
 import * as ac from 'atom/autocomplete-plus';
-import { Suggestion, TextSuggestion, SnippetSuggestion } from 'atom-ide';
+import { Suggestion, TextSuggestion, SnippetSuggestion } from '../types/autocomplete-extended';
 
 /**
  * Holds a list of suggestions generated from the CompletionItem[]

lib/types/autocomplete-extended.ts

@@ -0,0 +1,25 @@
+// Autocomplete extention (the properties added by atom-languageclient)
+// See this PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51284
+
+import * as ac from 'atom/autocomplete-plus';
+
+/** Adds LSP specific properties to the Atom SuggestionBase type */
+interface SuggestionBase extends ac.SuggestionBase {
+  /**
+   * A string that is used when filtering and sorting a set of
+   * completion items with a prefix present. When `falsy` the
+   * [displayText](#ac.SuggestionBase.displayText) is used. When
+   * no prefix, the `sortText` property is used.
+   */
+  filterText?: string;
+
+  /**
+   * String representing the replacement prefix from the suggestion's
+   * custom start point to the original buffer position the suggestion
+   * was gathered from.
+   */
+  customReplacmentPrefix?: string;
+}
+export type TextSuggestion = SuggestionBase & ac.TextSuggestion;
+export type SnippetSuggestion = SuggestionBase & ac.SnippetSuggestion;
+export type Suggestion =  TextSuggestion | SnippetSuggestion;

test/adapters/autocomplete-adapter.test.ts

@@ -9,7 +9,7 @@ import {
 import * as ac from 'atom/autocomplete-plus';
 import { expect } from 'chai';
 import { createSpyConnection, createFakeEditor } from '../helpers.js';
-import { TextSuggestion, SnippetSuggestion } from 'atom-ide';
+import { TextSuggestion, SnippetSuggestion } from '../../lib/types/autocomplete-extended';
 import { CompletionItem, MarkupContent, InsertTextFormat, TextEdit, Command } from '../../lib/languageclient';
 
 function createRequest({

typings/atom-ide/index.d.ts

@@ -1,36 +1,4 @@
 declare module 'atom-ide' {
-
   // atom-ide-base types for backward compatibility
   export * from "atom-ide-base/types-packages/main"
-
-  // NotificationButton for backward compatibility (moved to "../../lib/adapters/notifications-adapter")
-  export interface NotificationButton {
-    text: string
-  }
-
-  // Autocomplete extention (the properties added by atom-languageclient)
-  // See this PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51284
-
-  import * as ac from 'atom/autocomplete-plus';
-
-  /** Adds LSP specific properties to the Atom SuggestionBase type */
-  interface SuggestionBase extends ac.SuggestionBase {
-    /**
-     * A string that is used when filtering and sorting a set of
-     * completion items with a prefix present. When `falsy` the
-     * [displayText](#ac.SuggestionBase.displayText) is used. When
-     * no prefix, the `sortText` property is used.
-     */
-    filterText?: string;
-
-    /**
-     * String representing the replacement prefix from the suggestion's
-     * custom start point to the original buffer position the suggestion
-     * was gathered from.
-     */
-    customReplacmentPrefix?: string;
-  }
-  export type TextSuggestion = SuggestionBase & ac.TextSuggestion;
-  export type SnippetSuggestion = SuggestionBase & ac.SnippetSuggestion;
-  export type Suggestion =  TextSuggestion | SnippetSuggestion;
 }