Merge pull request #138 from atom-community/todos

chore: add more properties and TODOs

Author: aminya

lib/auto-languageclient.ts

@@ -110,12 +110,16 @@ export default class AutoLanguageClient {
       rootPath: projectPath,
       rootUri: Convert.pathToUri(projectPath),
       workspaceFolders: null,
+      // The capabilities supported.
+      // TODO the capabilities set to false/undefined are TODO. See {ls.ServerCapabilities} for a full list.
       capabilities: {
         workspace: {
           applyEdit: true,
           configuration: false,
           workspaceEdit: {
             documentChanges: true,
+            normalizesLineEndings: false,
+            changeAnnotationSupport: undefined,
           },
           workspaceFolders: false,
           didChangeConfiguration: {
@@ -124,12 +128,23 @@ export default class AutoLanguageClient {
           didChangeWatchedFiles: {
             dynamicRegistration: false,
           },
+          // BLOCKED: on atom/symbols-view
           symbol: {
             dynamicRegistration: false,
           },
           executeCommand: {
             dynamicRegistration: false,
           },
+          semanticTokens: undefined,
+          codeLens: undefined,
+          fileOperations: {
+            // BLOCKED: on tree-view not providing hooks for "before file/dir created"
+            willCreate: false,
+            // BLOCKED: on tree-view not providing hooks for "before file/dir renamed"
+            willRename: false,
+            // BLOCKED: on tree-view not providing hooks for "before file/dir deleted"
+            willDelete: false,
+          },
         },
         textDocument: {
           synchronization: {
@@ -152,6 +167,7 @@ export default class AutoLanguageClient {
           signatureHelp: {
             dynamicRegistration: false,
           },
+          declaration: undefined,
           references: {
             dynamicRegistration: false,
           },
@@ -189,13 +205,28 @@ export default class AutoLanguageClient {
           moniker: {
             dynamicRegistration: false,
           },
-
-          // We do not support these features yet.
-          // Need to set to undefined to appease TypeScript weak type detection.
+          publishDiagnostics: {
+            relatedInformation: true,
+            tagSupport: {
+              // BLOCKED: on steelbrain/linter supporting ways of denoting useless code and deprecated symbols
+              valueSet: [],
+            },
+            versionSupport: false,
+            codeDescriptionSupport: true,
+            dataSupport: true,
+          },
           implementation: undefined,
           typeDefinition: undefined,
           colorProvider: undefined,
           foldingRange: undefined,
+          selectionRange: undefined,
+          linkedEditingRange: undefined,
+          callHierarchy: undefined,
+          semanticTokens: undefined,
+        },
+        general: {
+          regularExpressions: undefined,
+          markdown: undefined,
         },
         experimental: {},
       },

lib/convert.ts

@@ -183,6 +183,8 @@ export default class Convert {
   }
 
   public static atomIdeDiagnosticToLSDiagnostic(diagnostic: atomIde.Diagnostic): ls.Diagnostic {
+    // TODO: support diagnostic codes and codeDescriptions
+    // TODO!: support data
     return {
       range: Convert.atomRangeToLSRange(diagnostic.range),
       severity: Convert.diagnosticTypeToLSSeverity(diagnostic.type),
@@ -223,6 +225,7 @@ export default class Convert {
    * @returns An Atom {atomIde.TextEdit} object.
    */
   public static convertLsTextEdit(textEdit: ls.TextEdit): atomIde.TextEdit {
+    // TODO: support annotations
     return {
       oldRange: Convert.lsRangeToAtomRange(textEdit.range),
       newText: textEdit.newText,