Skip to content

Commit e7c26b4

Browse files
committed
fix: early null check instead of empty array at codeActio provider
1 parent d665159 commit e7c26b4

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/adapters/code-action-adapter.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,18 @@ export default class CodeActionAdapter {
3939
editor: TextEditor,
4040
range: Range,
4141
diagnostics: atomIde.Diagnostic[]
42-
): Promise<atomIde.CodeAction[]> {
42+
): Promise<atomIde.CodeAction[] | null> {
4343
if (linterAdapter == null) {
4444
return []
4545
}
4646
assert(serverCapabilities.codeActionProvider, "Must have the textDocument/codeAction capability")
4747

4848
const params = CodeActionAdapter.createCodeActionParams(linterAdapter, editor, range, diagnostics)
4949
const actions = await connection.codeAction(params)
50-
return (actions || []).map((action) => CodeActionAdapter.createCodeAction(action, connection))
50+
if (!actions) {
51+
return null
52+
}
53+
return actions.map((action) => CodeActionAdapter.createCodeAction(action, connection))
5154
}
5255

5356
private static createCodeAction(

0 commit comments

Comments
 (0)