Merge pull request atom#23575 from icecream17/update-mksnapshot

fix/deps: min versions of electron-chromedriver...

Author: darangi

script/lib/check-chromedriver-version.js

@@ -5,6 +5,12 @@ const semver = require('semver');
 const chromedriverMetadataPath = require('electron-chromedriver/package.json');
 const mksnapshotMetadataPath = require('electron-mksnapshot/package.json');
 
+// The enviroment variable is usually set in install-script-dependencies.js
+const majorElectronVersion = semver.major(
+  process.env.ELECTRON_CUSTOM_VERSION ||
+    require('../config').appMetadata.electronVersion
+);
+
 module.exports = function() {
   // Chromedriver should be at least v9.0.0
   // Mksnapshot should be at least v9.0.2
@@ -26,15 +32,15 @@ module.exports = function() {
     );
   }
 
-  if (!semver.satisfies(chromedriverActualVer, '>=9.0.0')) {
+  if (!semver.satisfies(chromedriverActualVer, `>=${majorElectronVersion}`)) {
     throw new Error(
-      `electron-chromedriver should be at least v9.0.0 to support the ELECTRON_CUSTOM_VERSION environment variable.`
+      `electron-chromedriver should be at least v${majorElectronVersion} to support the ELECTRON_CUSTOM_VERSION environment variable.`
     );
   }
 
-  if (!semver.satisfies(mksnapshotActualVer, '>=9.0.2')) {
+  if (!semver.satisfies(mksnapshotActualVer, `>=${majorElectronVersion}`)) {
     throw new Error(
-      `electron-mksnapshot should be at least v9.0.2 to support the ELECTRON_CUSTOM_VERSION environment variable.`
+      `electron-mksnapshot should be at least v${majorElectronVersion} to support the ELECTRON_CUSTOM_VERSION environment variable.`
     );
   }
 };

script/package-lock.json

@@ -12,9 +12,9 @@
     "coffeelint": "1.15.7",
     "colors": "1.1.2",
     "donna": "1.0.16",
-    "electron-chromedriver": "^9.0.0",
+    "electron-chromedriver": "^11.0.0",
     "electron-link": "^0.6.0",
-    "electron-mksnapshot": "^9.0.2",
+    "electron-mksnapshot": "^11.0.1",
     "electron-packager": "^15.0.0",
     "eslint": "^5.16.0",
     "eslint-config-prettier": "^4.2.0",
@@ -37,7 +37,7 @@
     "nock": "^13.0.2",
     "node-fetch": "^3.1.1",
     "normalize-package-data": "2.3.5",
-    "npm": "6.14.8",
+    "npm": "^6.14.16",
     "npm-check": "^5.9.2",
     "passwd-user": "2.1.0",
     "pegjs": "0.9.0",