Skip to content

Commit 95dbf77

Browse files
committed
function to create coreRenderProcessTestSuites
only when needed
1 parent 3ab703b commit 95dbf77

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

script/test

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ function runCoreMainProcessTests (callback) {
102102
cp.on('close', exitCode => { callback(null, {exitCode, step: 'core-main-process', testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`}) })
103103
}
104104

105+
function getCoreRenderProcessTestSuites() {
106+
105107
// Build an array of functions, each running tests for a different rendering test
106108
const coreRenderProcessTestSuites = []
107109
const testPath = path.join(CONFIG.repositoryRootPath, 'spec')
@@ -133,6 +135,9 @@ for (let testFile of testFiles) {
133135
})
134136
}
135137

138+
return coreRenderProcessTestSuites
139+
}
140+
136141
// Build an array of functions, each running tests for a different bundled package
137142
const packageTestSuites = []
138143
for (let packageName in CONFIG.appMetadata.packageDependencies) {
@@ -231,7 +236,7 @@ function requestedTestSuites (platform) {
231236
let suites = []
232237
// Core tess
233238
if (coreAll) {
234-
suites.push(...[runCoreMainProcessTests, ...coreRenderProcessTestSuites])
239+
suites.push(...[runCoreMainProcessTests, ...getCoreRenderProcessTestSuites()])
235240
} else {
236241

237242
// Core main tests
@@ -241,14 +246,14 @@ function requestedTestSuites (platform) {
241246

242247
// Core renderer tests
243248
if (coreRenderer) {
244-
suites.push(...coreRenderProcessTestSuites)
249+
suites.push(...getCoreRenderProcessTestSuites())
245250
} else {
246251
// split
247252
if (coreRenderer1) {
248-
suites.push(...coreRenderProcessTestSuites.slice(0, CORE_RENDER_TO_TEST_IN_PARALLEL))
253+
suites.push(...getCoreRenderProcessTestSuites().slice(0, CORE_RENDER_TO_TEST_IN_PARALLEL))
249254
}
250255
if (coreRenderer2) {
251-
suites.push(...coreRenderProcessTestSuites.slice(CORE_RENDER_TO_TEST_IN_PARALLEL))
256+
suites.push(...getCoreRenderProcessTestSuites().slice(CORE_RENDER_TO_TEST_IN_PARALLEL))
252257
}
253258
}
254259

0 commit comments

Comments
 (0)