Skip to content

Commit dafca7e

Browse files
committed
deps: "downgrade" node-fetch to ^v2.6.7 in script/
This version has all the known security patches in v3.x, and is meanwhile the recommended version to use from CommonJS (NodeJS-style) modules, as opposed to ESM. Atom's build and CI scripts are all CommonJS as far as I know, so we should basically stay on node-fetch v2.x. This fixes the currently broken "Bump dependencies" job in Nightly CI. Effectively reverts ad1318e, AKA atom#23506, albeit with a more up-to-date patch version of node-fetch v2.x.
1 parent e157187 commit dafca7e

File tree

2 files changed

+5
-39
lines changed

2 files changed

+5
-39
lines changed

script/package-lock.json

Lines changed: 4 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

script/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"minidump": "^0.22.0",
3636
"mkdirp": "0.5.1",
3737
"nock": "^13.0.2",
38-
"node-fetch": "^3.1.1",
38+
"node-fetch": "^2.6.7",
3939
"normalize-package-data": "2.3.5",
4040
"npm": "^6.14.16",
4141
"npm-check": "^5.9.2",

0 commit comments

Comments
 (0)