fix: improve type-safety by the config files

Author: aminya

.vscode/settings.json

@@ -1,5 +1,5 @@
 {
-  "cSpell.words": ["globify"],
+  "cSpell.words": ["Globified", "globify"],
   "explorer.fileNesting.patterns": {
     "index.js": "*.js"
   }

src/astro.cts

@@ -1,4 +1,6 @@
-export const astroConfig = {
+import { Linter } from "eslint"
+
+export const astroConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   // astro files
   files: ["*.astro"],
   parser: "astro-eslint-parser",

src/coffeescript.cts

@@ -1,7 +1,8 @@
 import { pluginNodeRules } from "./plugin-node-rules.cjs"
 import { pluginImportRulesExtra } from "./plugin-import-rules.cjs"
+import { Linter } from "eslint"
 
-export const coffeeConfig = {
+export const coffeeConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   // CoffeeScript files
   files: ["**/*.coffee"],
   parser: "eslint-plugin-coffee",

src/cson.cts

@@ -1,6 +1,7 @@
+import { Linter } from "eslint"
 import { coffeeConfig } from "./coffeescript.cjs"
 
-export const csonConfig = {
+export const csonConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   ...coffeeConfig,
   files: ["**/*.cson"],
   rules: {

src/html.cts

@@ -1,4 +1,6 @@
-export const htmlConfig = {
+import { Linter } from "eslint"
+
+export const htmlConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   files: [
     "**/*.erb",
     "**/*.handlebars",

src/index-react.cts

@@ -1,20 +1,21 @@
+import { Linter } from "eslint"
 import base from "./index.cjs"
 import { tsConfig } from "./typescript.cjs"
 
-const nonStrictConfig = {
+const nonStrictConfig: Linter.Config = {
   ...base,
-  plugins: ["react", ...base.plugins],
-  extends: ["plugin:react/recommended", ...base.extends],
+  plugins: ["react", ...(base.plugins ?? [])],
+  extends: ["plugin:react/recommended", ...(base.extends ?? [])],
   overrides: [
     // TypeScript:
     {
       ...tsConfig,
-      plugins: ["react", ...tsConfig.plugins],
-      extends: ["plugin:react/recommended", ...tsConfig.extends],
+      plugins: ["react", ...(tsConfig.plugins ?? [])],
+      extends: ["plugin:react/recommended", ...(tsConfig.extends ?? [])],
       rules: tsConfig.rules,
     },
     // The rest is the same
-    ...base.overrides.slice(1),
+    ...(base.overrides?.slice(1) ?? []),
   ],
   settings: {
     ...base.settings,

src/index-solid.cts

@@ -1,20 +1,21 @@
+import { Linter } from "eslint"
 import base from "./index.cjs"
 import { tsConfig } from "./typescript.cjs"
 
-const nonStrictConfig = {
+const nonStrictConfig: Linter.Config = {
   ...base,
-  plugins: ["solid", ...base.plugins],
-  extends: ["plugin:solid/recommended", ...base.extends],
+  plugins: ["solid", ...(base.plugins ?? [])],
+  extends: ["plugin:solid/recommended", ...(base.extends ?? [])],
   overrides: [
     // TypeScript:
     {
       ...tsConfig,
-      plugins: ["solid", ...tsConfig.plugins],
-      extends: ["plugin:solid/typescript", ...tsConfig.extends],
+      plugins: ["solid", ...(tsConfig.plugins ?? [])],
+      extends: ["plugin:solid/typescript", ...(tsConfig.extends ?? [])],
       rules: tsConfig.rules,
     },
     // The rest is the same
-    ...base.overrides.slice(1),
+    ...(base.overrides?.slice(1) ?? []),
   ],
 }
 

src/index-strict-react.cts

@@ -1,13 +1,16 @@
 import nonStrictConfig from "./index-react.cjs"
 
 // remove only-warn from javascript
-if (nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn") {
+if (
+  nonStrictConfig.plugins !== undefined &&
+  nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn"
+) {
   nonStrictConfig.plugins.pop()
 }
 
 // remove only-warn from overrides
-nonStrictConfig.overrides.forEach((overrides) => {
-  if (overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
+nonStrictConfig.overrides?.forEach((overrides) => {
+  if (overrides.plugins !== undefined && overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
     overrides.plugins.pop()
   }
 })

src/index-strict-solid.cts

@@ -1,13 +1,16 @@
 import nonStrictConfig from "./index-solid.cjs"
 
 // remove only-warn from javascript
-if (nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn") {
+if (
+  nonStrictConfig.plugins !== undefined &&
+  nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn"
+) {
   nonStrictConfig.plugins.pop()
 }
 
 // remove only-warn from overrides
-nonStrictConfig.overrides.forEach((overrides) => {
-  if (overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
+nonStrictConfig.overrides?.forEach((overrides) => {
+  if (overrides.plugins !== undefined && overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
     overrides.plugins.pop()
   }
 })

src/index-strict.cts

@@ -1,13 +1,16 @@
 import nonStrictConfig from "./index.cjs"
 
 // remove only-warn from javascript
-if (nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn") {
+if (
+  nonStrictConfig.plugins !== undefined &&
+  nonStrictConfig.plugins[nonStrictConfig.plugins.length - 1] === "only-warn"
+) {
   nonStrictConfig.plugins.pop()
 }
 
 // remove only-warn from overrides
-nonStrictConfig.overrides.forEach((overrides) => {
-  if (overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
+nonStrictConfig.overrides?.forEach((overrides) => {
+  if (overrides.plugins !== undefined && overrides.plugins[overrides.plugins.length - 1] === "only-warn") {
     overrides.plugins.pop()
   }
 })