Merge pull request #41 from atom-ide-community/tree-copy-fix

Author: aminya

.clang-tidy

@@ -1,4 +1,4 @@
 ---
-Checks:          '*, -cppcoreguidelines-init-variables, -modernize-return-braced-init-list, -misc-unused-parameters, -misc-non-private-member-variables-in-classes, -llvmlibc-*, -llvm-header-guard, -llvm-include-order, -modernize-use-trailing-return-type, -readability-const-return-type, -readability-avoid-const-params-in-decls, -readability-convert-member-functions-to-static, -fuchsia-default-arguments-declarations, -fuchsia-default-arguments-calls, -*-uppercase-literal-suffix, -fuchsia-overloaded-operator, -google-build-using-namespace, -google-global-names-in-headers'
+Checks:          '*, -clang-diagnostics-*-compat, -cppcoreguidelines-init-variables, -modernize-return-braced-init-list, -misc-unused-parameters, -misc-non-private-member-variables-in-classes, -llvmlibc-*, -llvm-header-guard, -llvm-include-order, -modernize-use-trailing-return-type, -readability-const-return-type, -readability-avoid-const-params-in-decls, -readability-convert-member-functions-to-static, -fuchsia-default-arguments-declarations, -fuchsia-default-arguments-calls, -*-uppercase-literal-suffix, -fuchsia-overloaded-operator, -google-build-using-namespace, -google-global-names-in-headers'
 HeaderFilterRegex: '.*'
 FormatStyle:     none

src/tree.h

@@ -27,12 +27,12 @@ std::optional<Napi::Array> getChildren(const Napi::Object &jsTree, const string
 
 
 struct CandidateObject {
-    const CandidateString data;// TODO copy
+    const CandidateString data;
     const size_t level = 0;
     const size_t index = 0;
 
-    CandidateObject(const CandidateString data_, const size_t level_, const size_t index_) noexcept
-      : data{ data_ }, level{ level_ }, index{ index_ } {};
+    CandidateObject(const CandidateString &data_, const size_t level_, const size_t index_) noexcept
+      : data{ data_ }, level{ level_ }, index{ index_ } {}
 };
 
 template<typename T>
@@ -52,9 +52,9 @@ struct Tree {
     }
 
     /** 1st argument is a single object */
-    void makeEntriesArray(const Napi::Object &jsTree, const size_t level, const size_t iEntry = -1) {
+    void makeEntriesArray(const Napi::Object &jsTree, const size_t level, const size_t iEntry) {
         // get the current data
-        const auto &data = jsTree.Get(dataKey).ToString().Utf8Value();
+        const auto data = jsTree.Get(dataKey).ToString().Utf8Value();
         entriesArray.emplace_back(CandidateObject(data, level, iEntry));
 
         // add children if any