WIP: adding tests

Author: David-Desmaisons

src/core/componentBuilderHelper.js

@@ -1,50 +1,51 @@
-import { capitalize } from "../util/string";
-import { camelize } from "../util/string";
+import { capitalize, camelize } from "../util/string";
 import { events, isReadOnlyEvent } from "./sortableEvents";
 
 function isHtmlAttribute(value) {
   return ["id", "class"].includes(value) || value.startsWith("data-");
 }
 
-function getComponentAttributes({ $attrs, componentData }) {
-  const attributes = Object.entries($attrs)
-    .filter(([key, _]) => isHtmlAttribute(key))
-    .reduce((res, [key, value]) => {
-      res[key] = value;
-      return res;
-    }, {});
+function project(entries) {
+  return entries.reduce((res, [key, value]) => {
+    res[key] = value;
+    return res;
+  }, {});
+}
 
+function getComponentAttributes({ $attrs, componentData }) {
+  const attributes = project(
+    Object.entries($attrs).filter(([key, _]) => isHtmlAttribute(key))
+  );
   if (!componentData) {
     return attributes;
   }
   const { on, props, attrs } = componentData;
   Object.entries(on || {}).forEach(([key, value]) => {
     attributes[`on${capitalize(key)}`] = value;
   });
-  return { ...attributes, ...attrs, ...props };
+  return {
+    ...attributes,
+    ...attrs,
+    ...props
+  };
 }
 
 function createSortableOption({ $attrs, callBackBuilder }) {
-  const options = {
-    draggable: ">*"
-  };
-  Object.entries($attrs)
-    .filter(([key, _]) => !isHtmlAttribute(key))
-    .map(([key, value]) => [camelize(key), value])
-    .filter(([key, _]) => !isReadOnlyEvent(key))
-    .forEach(([key, value]) => {
-      options[key] = value;
-    });
+  const options = project(getValidSortableEntries($attrs));
   Object.entries(callBackBuilder).forEach(([eventType, eventBuilder]) => {
     events[eventType].forEach(event => {
       options[`on${event}`] = eventBuilder(event);
     });
   });
-  return options;
+  return {
+    draggable: ">*",
+    ...options
+  };
 }
 
 function getValidSortableEntries(value) {
   return Object.entries(value)
+    .filter(([key, _]) => !isHtmlAttribute(key))
     .map(([key, value]) => [camelize(key), value])
     .filter(([key, _]) => !isReadOnlyEvent(key));
 }

tests/unit/core/componentBuilderHelper.spec.js

@@ -1,10 +1,12 @@
 import {
   getComponentAttributes,
   createSortableOption,
+  getValidSortableEntries
 } from "@/core/componentBuilderHelper";
 
 describe("getComponentAttributes", () => {
   test.each([
+    [{ $attrs: {} }, {}],
     [{ $attrs: {}, componentData: {} }, {}],
     [
       {
@@ -36,6 +38,17 @@ describe("getComponentAttributes", () => {
         prop1: "value",
       },
     ],
+    [
+      {
+        $attrs: {
+          id: "value",
+          value: 89,
+        }
+      },
+      {
+        id: "value",
+      },
+    ],
     [
       {
         $attrs: {
@@ -58,6 +71,22 @@ describe("getComponentAttributes", () => {
         value: 89,
       },
     ],
+    [
+      {
+        $attrs: {
+        },
+        componentData: {
+          on: {
+            value: 89,
+            input: 66
+          },
+        },
+      },
+      {
+        onValue: 89,
+        onInput: 66
+      },
+    ],
   ])("for %o returns %o", (value, expected) => {
     const actual = getComponentAttributes(value);
     expect(actual).toEqual(expected);
@@ -150,3 +179,17 @@ describe("createSortableOption", () => {
     expect(actual).toEqual(expected);
   });
 });
+
+describe("getValidSortableEntries", () =>{
+  test.each([
+    [{newValue: 1}, [["newValue", 1]]],
+    [{onStart: 1}, []],
+    [{onStart: 1, newValue: 11}, [["newValue", 11]]],
+    [{onStart: 1, id: "newId", attribute: "yes"}, [["attribute",  "yes"]]],
+    [{onStart: 1, "data-bind": "value", boolean: true}, [["boolean", true]]]
+  ])
+  ("for %o returns %o", (value, expected) => {
+    const actual = getValidSortableEntries(value);
+    expect(actual).toEqual(expected);
+  });
+})