fix: Optimizations (#14)

Author: aminya

lib/minimap-bookmarks-binding.js

@@ -8,8 +8,8 @@ class MinimapBookmarksBinding {
 
 		this.subscriptions = new CompositeDisposable()
 		this.editor = this.minimap.getTextEditor()
-		this.decorationsByMarkerId = {}
-		this.decorationSubscriptionsByMarkerId = {}
+		this.decorationsByMarkerId = new Map()
+		this.decorationSubscriptionsByMarkerId = new Map()
 
 		// We need to wait until the bookmarks package had created its marker
 		// layer before retrieving its id from the state.
@@ -39,23 +39,26 @@ class MinimapBookmarksBinding {
 	handleMarker (marker) {
 		const { id } = marker
 		const decoration = this.minimap.decorateMarker(marker, { type: 'line', class: 'bookmark', plugin: 'bookmarks' })
-		this.decorationsByMarkerId[id] = decoration
-		this.decorationSubscriptionsByMarkerId[id] = decoration.onDidDestroy(() => {
-			this.decorationSubscriptionsByMarkerId[id].dispose()
+		this.decorationsByMarkerId.set(id, decoration)
+		this.decorationSubscriptionsByMarkerId.set(id,
+			decoration.onDidDestroy(() => {
+				this.decorationSubscriptionsByMarkerId.get(id).dispose()
 
-			delete this.decorationsByMarkerId[id]
-			delete this.decorationSubscriptionsByMarkerId[id]
-		})
+				this.decorationsByMarkerId.delete(id)
+				this.decorationSubscriptionsByMarkerId.delete(id)
+			}),
+		)
 	}
 
 	destroy () {
-		for (const id in this.decorationsByMarkerId) {
-			const decoration = this.decorationsByMarkerId[id]
-			this.decorationSubscriptionsByMarkerId[id].dispose()
+		const ids = this.decorationsByMarkerId.keys()
+		for (const id of ids) {
+			const decoration = this.decorationsByMarkerId.get(id)
+			this.decorationSubscriptionsByMarkerId.get(id).dispose()
 			decoration.destroy()
 
-			delete this.decorationsByMarkerId[id]
-			delete this.decorationSubscriptionsByMarkerId[id]
+			this.decorationsByMarkerId.delete(id)
+			this.decorationSubscriptionsByMarkerId.delete(id)
 		}
 
 		this.subscriptions.dispose()

lib/minimap-bookmarks.js

@@ -15,7 +15,7 @@ module.exports = {
 	activate () {
 		this.active = false
 		this.subscriptions = new CompositeDisposable()
-		this.bindings = {}
+		this.bindings = new Map()
 		require('atom-package-deps').install('minimap-git-diff')
 	},
 
@@ -49,13 +49,13 @@ module.exports = {
 			}
 
 			const binding = new MinimapBookmarksBinding(minimap, bookmarks)
-			this.bindings[minimap.id] = binding
+			this.bindings.set(minimap.id, binding)
 
 			const subscription = minimap.onDidDestroy(() => {
 				binding.destroy()
 				this.subscriptions.remove(subscription)
 				subscription.dispose()
-				delete this.bindings[minimap.id]
+				this.bindings.delete(minimap.id)
 			})
 			this.subscriptions.add(subscription)
 		})
@@ -64,8 +64,9 @@ module.exports = {
 	deactivatePlugin () {
 		if (!this.active) { return }
 
-		for (const id in this.bindings) { const binding = this.bindings[id]; binding.destroy() }
-		this.bindings = {}
+		const bindings = this.bindings.values()
+		for (const binding of bindings) { binding.destroy() }
+		this.bindings.clear()
 		this.active = false
 		this.minimapsSubscription.dispose()
 		this.subscriptions.dispose()

styles/minimap-bookmarks.less

@@ -5,5 +5,6 @@
 @import "ui-variables";
 
 .minimap .bookmark {
+  contain: layout size paint style;
   background: @background-color-info;
 }