Skip to content

Commit 3048fd6

Browse files
authored
Merge pull request #39 from richrace/master
Upgrade API consumed version + Add dependency warning
2 parents 60fcaf5 + 2043d03 commit 3048fd6

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

lib/minimap-highlight-selected.coffee

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@ class MinimapHighlightSelected
66
@subscriptions = new CompositeDisposable
77

88
activate: (state) ->
9+
unless atom.inSpecMode()
10+
require('atom-package-deps').install 'minimap-highlight-selected', true
911

1012
consumeMinimapServiceV1: (@minimap) ->
1113
@minimap.registerPlugin 'highlight-selected', this
1214

13-
consumeHighlightSelectedServiceV1: (@highlightSelected) ->
15+
consumeHighlightSelectedServiceV2: (@highlightSelected) ->
1416
@init() if @minimap? and @active?
1517

1618
deactivate: ->
@@ -34,21 +36,21 @@ class MinimapHighlightSelected
3436

3537
init: =>
3638
@decorations = []
37-
@highlightSelected.onDidAddMarker (marker) => @markerCreated(marker)
38-
@highlightSelected.onDidAddSelectedMarker (marker) => @markerCreated(marker, true)
39+
@highlightSelected.onDidAddMarkerForEditor (options) => @markerCreated(options)
40+
@highlightSelected.onDidAddSelectedMarkerForEditor (options) => @markerCreated(options, true)
3941
@highlightSelected.onDidRemoveAllMarkers => @markersDestroyed()
4042

4143
dispose: =>
4244
@decorations?.forEach (decoration) -> decoration.destroy()
4345
@decorations = null
4446

45-
markerCreated: (marker, selected = false) =>
46-
activeMinimap = @minimap.getActiveMinimap()
47-
return unless activeMinimap?
47+
markerCreated: (options, selected = false) =>
48+
minimap = @minimap.minimapForEditor(options.editor)
49+
return unless minimap?
4850
className = 'highlight-selected'
4951
className += ' selected' if selected
5052

51-
decoration = activeMinimap.decorateMarker(marker,
53+
decoration = minimap.decorateMarker(options.marker,
5254
{type: 'highlight', class: className })
5355
@decorations.push decoration
5456

package.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,17 @@
1616
},
1717
"highlightSelected": {
1818
"versions": {
19-
"1.0.0": "consumeHighlightSelectedServiceV1"
19+
"2.0.0": "consumeHighlightSelectedServiceV2"
2020
}
2121
}
2222
},
2323
"dependencies": {
2424
"event-kit": ">= 0.7.2",
2525
"underscore-plus": "1.x",
26-
"atom-utils": "0.0.1"
27-
}
26+
"atom-utils": "0.0.1",
27+
"atom-package-deps": "^4.4.1"
28+
},
29+
"package-deps": [
30+
"highlight-selected"
31+
]
2832
}

0 commit comments

Comments
 (0)