Merge pull request #712 from atom-ide-community/activation-hook-4upstream

Author: aminya

.github/workflows/CI.yml

@@ -54,7 +54,7 @@ jobs:
         run: npm run lint
 
   Release:
-    needs: Lint # [Test, Lint]
+    needs: [Test, Lint]
     if: github.ref == 'refs/heads/master' &&
       github.event.repository.fork == false
     runs-on: ubuntu-latest
@@ -68,14 +68,14 @@ jobs:
         run: npm install
       # - name: Build and Commit
       #   run: npm run build-commit
-      # - name: Release 🎉
-      #   uses: cycjimmy/semantic-release-action@v2
-      #   with:
-      #     extends: |
-      #       @semantic-release/apm-config
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #     ATOM_ACCESS_TOKEN: ${{ secrets.ATOM_ACCESS_TOKEN  }}
+      - name: Release 🎉
+        uses: cycjimmy/semantic-release-action@v2
+        with:
+          extends: |
+            @semantic-release/apm-config
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          ATOM_ACCESS_TOKEN: ${{ secrets.ATOM_ACCESS_TOKEN  }}
   Skip:
     if: contains(github.event.head_commit.message, '[skip ci]')
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -1,3 +1,7 @@
+# v4.30.1 (2020-11-20)
+
+- :sparkles: Startup time improvement: [fix: add activation hook](https://github.com/atom-minimap/minimap/pull/712)
+
 # v4.30.0 (2020-11-20)
 
 - :sparkles: Performance improvement: [Make event listeners passive](https://github.com/atom-minimap/minimap/pull/683)

package.json

@@ -40,6 +40,9 @@
   "viewProviders": [
     "minimapViewProvider"
   ],
+  "activationHooks": [
+    "core:loaded-shell-environment"
+  ],
   "configSchema": {
     "plugins": {
       "type": "object",

spec/minimap-element-spec.js

@@ -52,6 +52,11 @@ describe('MinimapElement', () => {
       ? document.body.querySelector('#jasmine-content')
       : document.body
 
+
+    // Package activation will be deferred to the configured, activation hook, which is then triggered
+    // Activate activation hook
+    atom.packages.triggerDeferredActivationHooks();
+    atom.packages.triggerActivationHook("core:loaded-shell-environment");
     waitsForPromise(() => atom.packages.activatePackage('minimap'))
 
     runs(() => {
@@ -1949,6 +1954,10 @@ describe('MinimapElement', () => {
       describe('with plugins registered in the package', () => {
         let [minimapPackage, pluginA, pluginB] = []
         beforeEach(() => {
+          // Package activation will be deferred to the configured, activation hook, which is then triggered
+          // Activate activation hook
+          atom.packages.triggerDeferredActivationHooks();
+          atom.packages.triggerActivationHook("core:loaded-shell-environment");
           waitsForPromise(() => {
             return atom.packages.activatePackage('minimap').then((pkg) => {
               minimapPackage = pkg.mainModule

spec/minimap-main-spec.js

@@ -16,6 +16,10 @@ describe('Minimap package', () => {
       return atom.workspace.open('sample.coffee')
     })
 
+    // Package activation will be deferred to the configured, activation hook, which is then triggered
+    // Activate activation hook
+    atom.packages.triggerDeferredActivationHooks();
+    atom.packages.triggerActivationHook("core:loaded-shell-environment");
     waitsForPromise(() => {
       return atom.packages.activatePackage('minimap').then((pkg) => {
         minimapPackage = pkg.mainModule
@@ -66,6 +70,10 @@ describe('Minimap package', () => {
           const m = new Minimap({textEditor: editor})
           const v = atom.views.getView(m)
           editorElement.appendChild(v)
+          // Package activation will be deferred to the configured, activation hook, which is then triggered
+          // Activate activation hook
+          atom.packages.triggerDeferredActivationHooks();
+          atom.packages.triggerActivationHook("core:loaded-shell-environment");
           waitsForPromise(() => atom.packages.activatePackage('minimap'))
         })