fix: removeChild before appending

aminya · aminya · commit 1d07ed154be2 · 2021-01-17T02:17:05.000-06:00
diff --git a/lib/minimap-element.js b/lib/minimap-element.js
@@ -427,7 +427,10 @@ class MinimapElement {
     const container = parent || this.minimap.getTextEditorElement()
     const minimaps = container.querySelectorAll('atom-text-editor-minimap')
     if (minimaps.length) {
-      Array.prototype.forEach.call(minimaps, (el) => { el.destroy() })
+      Array.prototype.forEach.call(minimaps, (el) => {
+        el.destroy()
+        container.removeChild(el)
+      })
     }
     container.appendChild(this)
   }

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,10 @@ class MinimapElement {`
`427`	`427`	`const container = parent \|\| this.minimap.getTextEditorElement()`
`428`	`428`	`const minimaps = container.querySelectorAll('atom-text-editor-minimap')`
`429`	`429`	`if (minimaps.length) {`
`430`		`- Array.prototype.forEach.call(minimaps, (el) => { el.destroy() })`
	`430`	`+ Array.prototype.forEach.call(minimaps, (el) => {`
	`431`	`+ el.destroy()`
	`432`	`+ container.removeChild(el)`
	`433`	`+ })`
`431`	`434`	`}`
`432`	`435`	`container.appendChild(this)`
`433`	`436`	`}`