fix: use Map for decorationMarkerChangedSubscriptionsValues

decorationMarkerChangedSubscriptions

Author: aminya

lib/mixins/decoration-management.js

@@ -44,7 +44,7 @@ export default class DecorationManagement {
      * @type {Object}
      * @access private
      */
-    this.decorationMarkerChangedSubscriptions = {}
+    this.decorationMarkerChangedSubscriptions = new Map()
     /**
      * The subscriptions to the markers `did-destroy` event indexed using the
      * marker id.
@@ -345,8 +345,8 @@ export default class DecorationManagement {
       })
     }
 
-    if (this.decorationMarkerChangedSubscriptions[id] == null) {
-      this.decorationMarkerChangedSubscriptions[id] =
+    if (!this.decorationMarkerChangedSubscriptions.has(id)) {
+      this.decorationMarkerChangedSubscriptions.set(id,
       marker.onDidChange((event) => {
         const decorations = this.decorationsByMarkerId.get(id)
         const screenRange = marker.getScreenRange()
@@ -390,7 +390,7 @@ export default class DecorationManagement {
             end: end
           }, 0)
         }
-      })
+      }))
     }
 
     const decoration = new Decoration(marker, this, decorationParams)
@@ -592,20 +592,21 @@ export default class DecorationManagement {
   removedAllMarkerDecorations (marker) {
     if (marker == null) { return }
 
-    this.decorationMarkerChangedSubscriptions[marker.id].dispose()
+    this.decorationMarkerChangedSubscriptions.get(marker.id).dispose()
     this.decorationMarkerDestroyedSubscriptions[marker.id].dispose()
 
     this.decorationsByMarkerId.delete(marker.id)
-    delete this.decorationMarkerChangedSubscriptions[marker.id]
+    this.decorationMarkerChangedSubscriptions.delete(marker.id)
     delete this.decorationMarkerDestroyedSubscriptions[marker.id]
   }
 
   /**
    * Removes all the decorations that was created in the current `Minimap`.
    */
   removeAllDecorations () {
-    for (const id in this.decorationMarkerChangedSubscriptions) {
-      this.decorationMarkerChangedSubscriptions[id].dispose()
+    const decorationMarkerChangedSubscriptionsValues = this.decorationMarkerChangedSubscriptions.values()
+    for (const decoration of decorationMarkerChangedSubscriptionsValues) {
+      decoration.dispose()
     }
 
     for (const id in this.decorationMarkerDestroyedSubscriptions) {
@@ -627,7 +628,7 @@ export default class DecorationManagement {
 
     this.decorationsById.clear()
     this.decorationsByMarkerId.clear()
-    this.decorationMarkerChangedSubscriptions = {}
+    this.decorationMarkerChangedSubscriptions.clear()
     this.decorationMarkerDestroyedSubscriptions = {}
     this.decorationUpdatedSubscriptions = {}
     this.decorationDestroyedSubscriptions = {}