fix: use Map for decorationUpdatedSubscriptions

Author: aminya

lib/mixins/decoration-management.js

@@ -58,7 +58,7 @@ export default class DecorationManagement {
      * @type {Object}
      * @access private
      */
-    this.decorationUpdatedSubscriptions = {}
+    this.decorationUpdatedSubscriptions = new Map()
     /**
      * The subscriptions to the decorations `did-destroy` event indexed using
      * the decoration id.
@@ -402,11 +402,11 @@ export default class DecorationManagement {
     this.decorationsByMarkerId.get(id).push(decoration)
     this.decorationsById.set(decoration.id, decoration)
 
-    if (this.decorationUpdatedSubscriptions[decoration.id] == null) {
-      this.decorationUpdatedSubscriptions[decoration.id] =
+    if (!this.decorationUpdatedSubscriptions.has(decoration.id)) {
+      this.decorationUpdatedSubscriptions.set(decoration.id,
       decoration.onDidChangeProperties((event) => {
         this.emitDecorationChanges(type, decoration)
-      })
+      }))
     }
 
     this.decorationDestroyedSubscriptions[decoration.id] =
@@ -526,13 +526,13 @@ export default class DecorationManagement {
 
     this.decorationsById.delete(decoration.id)
 
-    subscription = this.decorationUpdatedSubscriptions[decoration.id]
+    subscription = this.decorationUpdatedSubscriptions.get(decoration.id)
     if (subscription != null) { subscription.dispose() }
 
     subscription = this.decorationDestroyedSubscriptions[decoration.id]
     if (subscription != null) { subscription.dispose() }
 
-    delete this.decorationUpdatedSubscriptions[decoration.id]
+    this.decorationUpdatedSubscriptions.delete(decoration.id)
     delete this.decorationDestroyedSubscriptions[decoration.id]
 
     const decorations = this.decorationsByMarkerId.get(marker.id)
@@ -614,8 +614,9 @@ export default class DecorationManagement {
       decoration.dispose()
     }
 
-    for (const id in this.decorationUpdatedSubscriptions) {
-      this.decorationUpdatedSubscriptions[id].dispose()
+    const decorationUpdatedSubscriptionsValues = this.decorationUpdatedSubscriptions.values()
+    for (const decoration of decorationUpdatedSubscriptionsValues) {
+      decoration.dispose()
     }
 
     for (const id in this.decorationDestroyedSubscriptions) {
@@ -631,7 +632,7 @@ export default class DecorationManagement {
     this.decorationsByMarkerId.clear()
     this.decorationMarkerChangedSubscriptions.clear()
     this.decorationMarkerDestroyedSubscriptions.clear()
-    this.decorationUpdatedSubscriptions = {}
+    this.decorationUpdatedSubscriptions.clear()
     this.decorationDestroyedSubscriptions = {}
   }
 }