Skip to content

Commit dc078fe

Browse files
committed
fix: try catch removeChild inside attach
1 parent 3d73a90 commit dc078fe

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/main.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ export function toggle () {
166166
if (wasMaximized) {
167167
atom.maximize()
168168
}
169-
170169
} else {
171170
toggled = true
172171
initSubscriptions()

lib/minimap-element.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,12 @@ class MinimapElement {
429429
if (minimaps.length) {
430430
Array.prototype.forEach.call(minimaps, (el) => {
431431
el.destroy()
432-
container.removeChild(el)
432+
try {
433+
container.removeChild(el)
434+
} catch (e) {
435+
// TODO: ignore for now
436+
// https://github.com/atom-minimap/minimap/issues/766#issuecomment-762496374
437+
}
433438
})
434439
}
435440
container.appendChild(this)

0 commit comments

Comments
 (0)