fix: don't destory the dummty decoration

Author: aminya

lib/decoration.js

@@ -88,8 +88,7 @@ export default class Decoration {
       return
     }
 
-    this.markerDestroyDisposable.dispose()
-    this.markerDestroyDisposable = null
+    this.markerDestroyDisposable?.dispose?.()
     this.destroyed = true
     this.emitter.emit("did-destroy")
     this.emitter.dispose()

lib/minimap.js

@@ -12,10 +12,9 @@ const disposedDisposable = new Disposable()
 disposedDisposable.dispose()
 const markerMock = {
   onDidDestroy: () => disposedDisposable,
-  getScreenRange: () => ({}),
+  getScreenRange: () => new Range(),
 }
-const destoryedDecoration = new Decoration(markerMock, null, {})
-destoryedDecoration.destroy()
+const dummyDecoration = new Decoration(markerMock, null, {})
 
 /**
  * The Minimap class is the underlying model of a <MinimapElement>.
@@ -1148,16 +1147,16 @@ export default class Minimap {
     return this.getDecorationManagement()?.onDidUpdateDecoration(...args) ?? disposedDisposable
   }
   decorationForId(...args) {
-    return this.getDecorationManagement()?.decorationForId(...args) ?? destoryedDecoration
+    return this.getDecorationManagement()?.decorationForId(...args) ?? dummyDecoration
   }
   decorationsForScreenRowRange(...args) {
-    return this.getDecorationManagement()?.decorationsForScreenRowRange(...args) ?? destoryedDecoration
+    return this.getDecorationManagement()?.decorationsForScreenRowRange(...args) ?? dummyDecoration
   }
   decorationsByTypeThenRows() {
-    return this.getDecorationManagement()?.decorationsByTypeThenRows() ?? destoryedDecoration
+    return this.getDecorationManagement()?.decorationsByTypeThenRows() ?? dummyDecoration
   }
   decorateMarker(...args) {
-    return this.getDecorationManagement()?.decorateMarker(...args) ?? destoryedDecoration
+    return this.getDecorationManagement()?.decorateMarker(...args) ?? dummyDecoration
   }
   removeDecoration(...args) {
     return this.getDecorationManagement()?.removeDecoration(...args)