require('shell') --> require('electron').shell (#1096)

Requiring 'shell' is deprecated in Electron;
It should be `require('electron').shell` now.

Author: DeeDeeG

lib/autocomplete-manager.js

@@ -227,7 +227,7 @@ class AutocompleteManager {
         let descriptionContainer = suggestionListView.querySelector('.suggestion-description')
         if (descriptionContainer !== null && descriptionContainer.style.display === 'block') {
           let descriptionMoreLink = descriptionContainer.querySelector('.suggestion-description-more-link')
-          require('shell').openExternal(descriptionMoreLink.href)
+          require('electron').shell.openExternal(descriptionMoreLink.href)
         }
       }
     }))

spec/autocomplete-manager-integration-spec.js

@@ -1990,7 +1990,7 @@ defm`
     describe('Keybind to navigate to descriptionMoreLink', () => {
       it('triggers openExternal on keybind if there is a description', async () => {
         spyOn(provider, 'getSuggestions').andCallFake(() => [{text: 'ab', description: 'it is ab'}])
-        let shell = require('shell')
+        let shell = require('electron').shell
         spyOn(shell, 'openExternal')
 
         triggerAutocompletion(editor, true, 'a')
@@ -2003,7 +2003,7 @@ defm`
 
       it('does not trigger openExternal on keybind if there is not a description', async () => {
         spyOn(provider, 'getSuggestions').andCallFake(() => [{text: 'ab'}])
-        let shell = require('shell')
+        let shell = require('electron').shell
         spyOn(shell, 'openExternal')
 
         triggerAutocompletion(editor, true, 'a')