Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit ed12ea7

Browse files
illrightaminya
andauthored
Upgrade to Jasmine 3 (#1103)
* Install the custom Atom test runner powered by Jasmine 3 * Upgrade the Jasmine API to the latest * Fix linter errors * Update spec/custom-runner.js Co-authored-by: Amin Yahyaabadi <[email protected]> Co-authored-by: Amin Yahyaabadi <[email protected]>
1 parent 3bdb3f2 commit ed12ea7

9 files changed

+294
-98
lines changed

package-lock.json

Lines changed: 202 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
},
1111
"dependencies": {
1212
"atom-slick": "^2.0.0",
13-
"dompurify": "^2.0.7",
13+
"dompurify": "^2.2.6",
1414
"fuzzaldrin": "^2.1.0",
1515
"fuzzaldrin-plus": "^0.6.0",
1616
"grim": "^2.0.1",
@@ -21,6 +21,7 @@
2121
"underscore-plus": "^1.6.6"
2222
},
2323
"devDependencies": {
24+
"atom-jasmine3-test-runner": "^5.1.8",
2425
"coffeelint": "^1.9.7",
2526
"fs-plus": ">=2.4.0",
2627
"standard": "^8.3.0",
@@ -254,5 +255,6 @@
254255
"ignore": [
255256
"**/spec/fixtures/**"
256257
]
257-
}
258+
},
259+
"atomTestRunner": "./spec/custom-runner"
258260
}

spec/autocomplete-manager-autosave-spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ return sort(Array.apply(this, arguments));
7171
})
7272
}
7373

74-
spyOn(autocompleteManager, 'displaySuggestions').andCallFake((suggestions, options) => {
74+
spyOn(autocompleteManager, 'displaySuggestions').and.callFake((suggestions, options) => {
7575
displaySuggestions(suggestions, options)
7676
for (const resolve of suggestionsPromises) {
7777
resolve()

0 commit comments

Comments
 (0)