This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
GrammarRegistry docs link to wrong locationΒ #736
Copy link
Copy link
Open
Description
Prerequisites
-
Done all of the following
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=β&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
https://flight-manual.atom.io/api/v1.57.0/GrammarRegistry/ links to the wrong location.
Should be atom@1.57.0/src/grammar-registry.js
But got first-mate@7.4.1/src/grammar-registry.coffee
Steps to Reproduce
Reproduces how often:
100%
Additional Information
Discovered by inconsistent types at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/atom/src/grammar-registry.d.ts which are difference than the actual methods.
It seems that FirstMate's grammar registry is used for GrammarRegistry#textmateRegistry https://github.com/atom/atom/search?q=FirstMate
The methods are similar but not exactly the same. For example, GrammarRegistry doesn't have onDidRemoveGrammar
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels