update test cases

Author: wadethestealth

lib/views/tab-header-view.js

@@ -8,7 +8,7 @@ export default class TabHeaderView extends React.Component {
 
     handleWorkDirSelect: PropTypes.func,
     onDidChangeWorkDirs: PropTypes.func,
-    getCurrentWorkDirs: PropTypes.func,
+    getCurrentWorkDirs: PropTypes.func.isRequired,
   }
 
   constructor(props) {

test/views/git-tab-view.test.js

@@ -286,7 +286,7 @@ describe('GitTabView', function() {
   it('calls changeWorkingDirectory when a project is selected', async function() {
     const changeWorkingDirectory = sinon.spy();
     const wrapper = shallow(await buildApp({changeWorkingDirectory}));
-    wrapper.find('TabHeaderView').prop('handleProjectSelect')({target: {value: 'some-path'}});
+    wrapper.find('TabHeaderView').prop('handleWorkDirSelect')({target: {value: 'some-path'}});
     assert.isTrue(changeWorkingDirectory.calledWith('some-path'));
   });
 });

test/views/github-tab-view.test.js

@@ -67,7 +67,7 @@ describe('GitHubTabView', function() {
   it('calls changeWorkingDirectory when a project is selected', async function() {
     const changeWorkingDirectory = sinon.spy();
     const wrapper = shallow(await buildApp({changeWorkingDirectory}));
-    wrapper.find('TabHeaderView').prop('handleProjectSelect')({target: {value: 'some-path'}});
+    wrapper.find('TabHeaderView').prop('handleWorkDirSelect')({target: {value: 'some-path'}});
     assert.isTrue(changeWorkingDirectory.calledWith('some-path'));
   });
 });

test/views/tab-header-view.test.js

@@ -5,29 +5,91 @@ import path from 'path';
 import TabHeaderView from '../../lib/views/tab-header-view';
 
 describe('TabHeaderView', function() {
-  let wrapper, select;
-  const path1 = 'test/path/project1';
-  const path2 = '2nd-test/path/project2';
-  const paths = [path1, path2];
-
-  beforeEach(function() {
-    select = sinon.spy();
-    wrapper = shallow(<TabHeaderView handleProjectSelect={select} projectPaths={paths} currentProject={path2} />);
-  });
+  function build(options = {}) {
+    const props = {
+      currentWorkDir: undefined,
+      onDidChangeWorkDirs: undefined,
+      handleWorkDirSelect: undefined,
+      getCurrentWorkDirs: () => [],
+      ...options,
+    }
+    return shallow(<TabHeaderView {...props}/>);
+  }
+
+  describe('with a select listener and paths', function() {
+    let wrapper, select;
+    const path1 = path.normalize('test/path/project1');
+    const path2 = path.normalize('2nd-test/path/project2');
+    const paths = [path1, path2];
+
+    beforeEach(function() {
+      select = sinon.spy();
+      wrapper = build({handleWorkDirSelect: select, getCurrentWorkDirs: () => paths, currentWorkDir: path2});
+    });
+
+    it('renders an option for all given working directories', function() {
+      wrapper.find('option').forEach(function(node, index) {
+        assert.strictEqual(node.props().value, paths[index]);
+        assert.strictEqual(node.children().text(), path.basename(paths[index]));
+      });
+    });
 
-  it('renders an option for all given project paths', function() {
-    wrapper.find('option').forEach(function(node, index) {
-      assert.strictEqual(node.props().value, paths[index]);
-      assert.strictEqual(node.children().text(), path.basename(paths[index]));
+    it('selects the current working directory\'s path', function() {
+      assert.strictEqual(wrapper.find('select').props().value, path2);
     });
+
+    it('calls handleWorkDirSelect on select', function() {
+      wrapper.find('select').simulate('change', {target: {value: path1}});
+      assert.isTrue(select.calledWith({target: {value: path1}}));
+    });
+
+    it('updates paths', function() {
+      const path3 = 'test3/path/project3';
+      paths.push(path3);
+      wrapper.instance().updateWorkDirs();
+      assert.strictEqual(wrapper.find('option').length, 3);
+    })
   });
 
-  it('selects the current project\'s path', function() {
-    assert.strictEqual(wrapper.find('select').props().value, path2);
+  describe('with onDidChangeWorkDirs', function() {
+    let wrapper, changeSpy, disposeSpy;
+
+    beforeEach(function() {
+      disposeSpy = sinon.spy();
+      const stub = sinon.stub().callsFake(function(updateWorkDirs) {
+        updateWorkDirs();
+        return {dispose: disposeSpy};
+      });
+      changeSpy = sinon.spy(stub);
+      wrapper = build({onDidChangeWorkDirs: changeSpy});
+    });
+
+    it('calls onDidChangeWorkDirs with updateWorkDirs', function() {
+      assert.isTrue(changeSpy.calledWith(wrapper.instance().updateWorkDirs));
+    });
+
+    it('calls dispose on unmount', function() {
+      wrapper.unmount();
+      assert.isTrue(disposeSpy.called);
+    });
+
+    it('does nothing on unmount without a disposable', function() {
+      wrapper.instance().disposable = undefined;
+      wrapper.unmount();
+      assert.isFalse(disposeSpy.called);
+    });
+
   });
 
-  it('calls handleProjectSelect on select', function() {
-    wrapper.find('select').simulate('change', {target: {value: path1}});
-    assert.isTrue(select.calledWith({target: {value: path1}}));
+  describe('with no paths', function() {
+    let wrapper;
+
+    beforeEach(function() {
+      wrapper = build();
+    });
+
+    it('renders no options', function() {
+      assert.isTrue(wrapper.find('select').children().isEmpty());
+    });
   });
 });