Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 2192a25

Browse files
lints
1 parent 95dcc1b commit 2192a25

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

test/containers/comment-decorations-container.test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ describe('CommentDecorationsContainer', function() {
184184

185185
it('renders nothing if query errors', function() {
186186
const tokenWrapper = localRepoWrapper.find(ObserveModel).renderProp('children')('1234');
187-
const stub = sinon.stub(console, 'warn');
188187
const resultWrapper = tokenWrapper.find(QueryRenderer).renderProp('render')({
189188
error: 'oh noes', props: null, retry: () => {}});
190189
assert.isTrue(resultWrapper.isEmptyRender());
@@ -255,7 +254,6 @@ describe('CommentDecorationsContainer', function() {
255254
const resultWrapper = tokenWrapper.find(QueryRenderer).renderProp('render')({
256255
error: null, props, retry: () => {},
257256
});
258-
const stub = sinon.stub(console, 'warn');
259257
const reviewsWrapper = resultWrapper.find(AggregatedReviewsContainer).renderProp('children')({
260258
errors: [new Error('ahhhh')],
261259
summaries: [],
@@ -343,7 +341,6 @@ describe('CommentDecorationsContainer', function() {
343341
{thread: {id: 'thread0'}, comments: [{id: 'comment0', path: 'a.txt'}, {id: 'comment1', path: 'a.txt'}]},
344342
],
345343
});
346-
const stub = sinon.stub(console, 'warn');
347344
const patchWrapper = reviewsWrapper.find(PullRequestPatchContainer).renderProp('children')(
348345
new Error('oops'), null,
349346
);

test/containers/issueish-search-container.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ describe('IssueishSearchContainer', function() {
8888
});
8989

9090
describe('when the query errors', function() {
91+
// eslint-disable-next-line no-unused-vars
9192
let stub;
9293
// Consumes the failing Relay Query console error
9394
beforeEach(function() {

test/controllers/comment-decorations-controller.test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,16 @@ describe('CommentDecorationsController', function() {
3434
const branch = new Branch('featureBranch', upstreamBranch, upstreamBranch, true);
3535
const {commentThreads} = aggregatedReviewsBuilder()
3636
.addReviewThread(t => {
37-
t.addComment(c => c.id("0").path('file0.txt').position(2).bodyHTML('one'));
37+
t.addComment(c => c.id('0').path('file0.txt').position(2).bodyHTML('one'));
3838
})
3939
.addReviewThread(t => {
40-
t.addComment(c => c.id("1").path('file1.txt').position(15).bodyHTML('two'));
40+
t.addComment(c => c.id('1').path('file1.txt').position(15).bodyHTML('two'));
4141
})
4242
.addReviewThread(t => {
43-
t.addComment(c => c.id("2").path('file2.txt').position(7).bodyHTML('three'));
43+
t.addComment(c => c.id('2').path('file2.txt').position(7).bodyHTML('three'));
4444
})
4545
.addReviewThread(t => {
46-
t.addComment(c => c.id("3").path('file2.txt').position(10).bodyHTML('four'));
46+
t.addComment(c => c.id('3').path('file2.txt').position(10).bodyHTML('four'));
4747
})
4848
.build();
4949

@@ -145,11 +145,11 @@ describe('CommentDecorationsController', function() {
145145
it('skips comment thread with only minimized comments', async function() {
146146
const {commentThreads} = aggregatedReviewsBuilder()
147147
.addReviewThread(t => {
148-
t.addComment(c => c.id("0").path('file0.txt').position(2).bodyHTML('one').isMinimized(true));
149-
t.addComment(c => c.id("2").path('file0.txt').position(2).bodyHTML('two').isMinimized(true));
148+
t.addComment(c => c.id('0').path('file0.txt').position(2).bodyHTML('one').isMinimized(true));
149+
t.addComment(c => c.id('2').path('file0.txt').position(2).bodyHTML('two').isMinimized(true));
150150
})
151151
.addReviewThread(t => {
152-
t.addComment(c => c.id("1").path('file1.txt').position(15).bodyHTML('three'));
152+
t.addComment(c => c.id('1').path('file1.txt').position(15).bodyHTML('three'));
153153
})
154154
.build();
155155
await atomEnv.workspace.open(path.join(__dirname, 'file0.txt'));

0 commit comments

Comments
 (0)