Update shell.openExternal stubs

Author: sadick254

test/controllers/issueish-list-controller.test.js

@@ -90,15 +90,15 @@ describe('IssueishListController', function() {
 
     it('calls shell.openExternal with specified url', async function() {
       const wrapper = shallow(buildApp());
-      sinon.stub(shell, 'openExternal').callsArg(2);
+      sinon.stub(shell, 'openExternal').callsFake(() => { });
 
       await wrapper.instance().openOnGitHub(url);
       assert.isTrue(shell.openExternal.calledWith(url));
     });
 
     it('fires `open-issueish-in-browser` event upon success', async function() {
       const wrapper = shallow(buildApp());
-      sinon.stub(shell, 'openExternal').callsArg(2);
+      sinon.stub(shell, 'openExternal').callsFake(() => {});
       sinon.stub(reporterProxy, 'addEvent');
 
       await wrapper.instance().openOnGitHub(url);
@@ -109,7 +109,7 @@ describe('IssueishListController', function() {
 
     it('handles error when openOnGitHub fails', async function() {
       const wrapper = shallow(buildApp());
-      sinon.stub(shell, 'openExternal').callsArgWith(2, new Error('oh noes'));
+      sinon.stub(shell, 'openExternal').throws(new Error('oh noes'));
       sinon.stub(reporterProxy, 'addEvent');
 
       try {

test/controllers/remote-controller.test.js

@@ -52,7 +52,7 @@ describe('RemoteController', function() {
 
   it('increments a counter when onCreatePr is called', async function() {
     const wrapper = shallow(createApp());
-    sinon.stub(shell, 'openExternal').callsArg(2);
+    sinon.stub(shell, 'openExternal').callsFake(() => {});
     sinon.stub(reporterProxy, 'incrementCounter');
 
     await wrapper.instance().onCreatePr();
@@ -62,7 +62,7 @@ describe('RemoteController', function() {
 
   it('handles error when onCreatePr fails', async function() {
     const wrapper = shallow(createApp());
-    sinon.stub(shell, 'openExternal').callsArgWith(2, new Error('oh noes'));
+    sinon.stub(shell, 'openExternal').throws(new Error('oh noes'));
     sinon.stub(reporterProxy, 'incrementCounter');
 
     try {

test/views/actionable-review-view.test.js

@@ -69,39 +69,38 @@ describe('ActionableReviewView', function() {
       }
 
       it("opens the content object's URL with 'Open on GitHub'", async function() {
-        sinon.stub(shell, 'openExternal').callsArg(2);
+        sinon.stub(shell, 'openExternal').callsFake(() => {});
 
         const item = triggerMenu({url: 'https://github.com'}, {}).items.find(i => i.label === 'Open on GitHub');
         await item.click();
 
-        assert.isTrue(shell.openExternal.calledWith('https://github.com', {}));
+        assert.isTrue(shell.openExternal.calledWith('https://github.com'));
         assert.isTrue(reporterProxy.addEvent.calledWith('open-comment-in-browser'));
       });
 
       it("rejects the promise when 'Open on GitHub' fails", async function() {
-        sinon.stub(shell, 'openExternal').callsArgWith(2, new Error("I don't feel like it"));
+        sinon.stub(shell, 'openExternal').throws(new Error("I don't feel like it"));
 
         const item = triggerMenu({url: 'https://github.com'}, {}).items.find(i => i.label === 'Open on GitHub');
         await assert.isRejected(item.click());
         assert.isFalse(reporterProxy.addEvent.called);
       });
 
       it('opens a prepopulated abuse-reporting link with "Report abuse"', async function() {
-        sinon.stub(shell, 'openExternal').callsArg(2);
+        sinon.stub(shell, 'openExternal').callsFake(() => {});
 
         const item = triggerMenu({url: 'https://github.com/a/b'}, {login: 'tyrion'})
           .items.find(i => i.label === 'Report abuse');
         await item.click();
 
         assert.isTrue(shell.openExternal.calledWith(
           'https://github.com/contact/report-content?report=tyrion&content_url=https%3A%2F%2Fgithub.com%2Fa%2Fb',
-          {},
         ));
         assert.isTrue(reporterProxy.addEvent.calledWith('report-abuse'));
       });
 
       it("rejects the promise when 'Report abuse' fails", async function() {
-        sinon.stub(shell, 'openExternal').callsArgWith(2, new Error('nah'));
+        sinon.stub(shell, 'openExternal').throws(new Error('nah'));
 
         const item = triggerMenu({url: 'https://github.com/a/b'}, {login: 'tyrion'})
           .items.find(i => i.label === 'Report abuse');

test/views/github-dotcom-markdown.test.js

@@ -213,7 +213,7 @@ describe('GithubDotcomMarkdown', function() {
     });
 
     it('records event for opening issueish in browser', async function() {
-      sinon.stub(shell, 'openExternal').callsArg(2);
+      sinon.stub(shell, 'openExternal').callsFake(() => {});
       sinon.stub(reporterProxy, 'addEvent');
 
       const issueishLink = wrapper.getDOMNode().querySelector('a.issue-link');
@@ -228,7 +228,7 @@ describe('GithubDotcomMarkdown', function() {
     });
 
     it('does not record event if opening issueish in browser fails', function() {
-      sinon.stub(shell, 'openExternal').callsArgWith(2, new Error('oh noes'));
+      sinon.stub(shell, 'openExternal').throws(new Error('oh noes'));
       sinon.stub(reporterProxy, 'addEvent');
 
       // calling `handleClick` directly rather than dispatching event so that we can catch the error thrown and prevent errors in the console