Merge pull request #2573 from atom/deflake-test

Correct a flaky test

Author: smashwilson

test/containers/github-tab-container.test.js

@@ -195,10 +195,11 @@ describe('GitHubTabContainer', function() {
       branches = new BranchSet([otherBranch, mainBranch]);
     });
 
-    function installRemoteSet(remoteSet) {
-      return Promise.all(
-        Array.from(remoteSet, remote => loadedRepo.addRemote(remote.getName(), remote.getUrl())),
-      );
+    async function installRemoteSet(remoteSet) {
+      for (const remote of remoteSet) {
+        // In your face, no-await-in-loop rule
+        await loadedRepo.addRemote(remote.getName(), remote.getUrl());
+      }
     }
 
     it('derives the subset of GitHub remotes', async function() {